Attachment 111123 Details for Bug 26595 – Bug 26595: Add smtp_server_info embed option to /libraries

[patch] Bug 26595: Add smtp_server_info embed option to /libraries

Bug-26595-Add-smtpserverinfo-embed-option-to-libra.patch (text/plain), 2.06 KB, created by Tomás Cohen Arazi (tcohen) on 2020-10-02 11:19:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-10-02 11:19:08 UTC

Size: 2.06 KB

patch

obsolete

>From b2e615b5e75cdc6ffc47056ecbec0d6894b9814f Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 1 Oct 2020 12:07:38 -0300
>Subject: [PATCH] Bug 26595: Add smtp_server_info embed option to /libraries
>
>This patch simply adds the option to embed the return value from
>Koha::Library->smtp_server_info on the libraries GET actions.
>---
> api/v1/swagger/definitions/library.json | 14 ++++++++++++++
> api/v1/swagger/paths/libraries.json     | 10 ++++++++--
> 2 files changed, 22 insertions(+), 2 deletions(-)
>
>diff --git a/api/v1/swagger/definitions/library.json b/api/v1/swagger/definitions/library.json
>index d31a83ff18..bae291cefd 100644
>--- a/api/v1/swagger/definitions/library.json
>+++ b/api/v1/swagger/definitions/library.json
>@@ -83,6 +83,20 @@
>     "pickup_location": {
>         "type": "boolean",
>         "description": "If the library can act as a pickup location"
>+    },
>+    "smtp_server_info": {
>+        "type": "object",
>+        "properties": {
>+          "name": {
>+            "description": "SMTP server name. 'system_default' if no SMTP server is assigned",
>+            "type": "string"
>+          },
>+          "smtp_server_id": {
>+            "description": "Internal identifier for the SMTP server",
>+            "type": ["integer", "null"]
>+          }
>+        },
>+        "description": "The library effective SMTP server information."
>     }
>   },
>   "additionalProperties": false,
>diff --git a/api/v1/swagger/paths/libraries.json b/api/v1/swagger/paths/libraries.json
>index 43c4673d5c..23131a3684 100644
>--- a/api/v1/swagger/paths/libraries.json
>+++ b/api/v1/swagger/paths/libraries.json
>@@ -178,7 +178,10 @@
>         "permissions": {
>           "catalogue": "1"
>         }
>-      }
>+      },
>+      "x-koha-embed": [
>+        "smtp_server_info"
>+      ]
>     },
>     "post": {
>       "x-mojo-to": "Libraries#add",
>@@ -284,7 +287,10 @@
>         "permissions": {
>           "catalogue": "1"
>         }
>-      }
>+      },
>+      "x-koha-embed": [
>+        "smtp_server_info"
>+      ]
>     },
>     "put": {
>       "x-mojo-to": "Libraries#update",
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 26595: 111122 | 111123 | 111124 | 111125 | 111155 | 111156 | 111157 | 111158 | 111550 | 111551 | 111552 | 111553 | 111606 | 111621 | 111622