Attachment 111184 Details for Bug 26606 – Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record

[patch] Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record

Bug-26606-Correctly-URI-encode-query-string-in-URL.patch (text/plain), 1.91 KB, created by Phil Ringnalda on 2020-10-02 22:43:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Ringnalda

Created: 2020-10-02 22:43:16 UTC

Size: 1.91 KB

patch

obsolete

>From be2ba68d905cb5254966ab4437ac83cfaa6a0722 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Fri, 2 Oct 2020 15:35:04 -0700
>Subject: [PATCH] Bug 26606: Correctly URI-encode query string in URL loaded
> after deleting an authority record
>
>If you search for "this & that" and delete one of the results, after
>it is deleted the search in the reloaded page is for "this " rather
>than for "this & that". The template uses the url filter, which is
>for filtering an entire URI where :, &, #, etc. should be left alone,
>rather than the uri filter which is for filtering a URI component
>where they should be encoded.
>
>To test:
>1) Go to Authorities > New authority > New from Z39.50/SRU
>2) Search for the Author (corporate) this & that collective
>3) Actions > Import, Save
>4) From the detail for that authority, Edit > Edit as new (duplicate)
>5) Edit the 110 field, add 2 at the end and Save
>6) Search authorities for this & that
>7) For one of the ones you created, Actions > Delete, confirm
>8) The page that reloads should have a search for this & that, not
>just for this
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
>index a788fee20a..a7d277ef84 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
>@@ -47,7 +47,7 @@ function confirm_deletion(id) {
>           + "&excluding=[% excluding | html %]"
>           + "&operator=[% operator | html %]"
>           + "&orderby=[% orderby | html %]"
>-          + "&value=[% value |url %]"
>+          + "&value=[% value |uri %]"
>           + "&startfrom=[% startfrom | html %]"
>           + "&resultsperpage=[% resultsperpage | html %]"
>           + "&csrf_token=[% csrf_token | html %]";
>-- 
>2.26.1

Actions: View | Diff | Splinter Review

Attachments on bug 26606: 111184 | 111208 | 111749