Bugzilla – Attachment 111274 Details for
Bug 22750
Partial writeoff of lost fee causes item to be returned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22750: (24474: Add `onpayment` option to `MarkLostItemsReturned`)
Bug-22750-24474-Add-onpayment-option-to-MarkLostIt.patch (text/plain), 3.25 KB, created by
Martin Renvoize (ashimema)
on 2020-10-06 09:53:45 UTC
(
hide
)
Description:
Bug 22750: (24474: Add `onpayment` option to `MarkLostItemsReturned`)
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-10-06 09:53:45 UTC
Size:
3.25 KB
patch
obsolete
>From fb31064e976572c077db601f9694b705de41845a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 5 Feb 2020 10:14:05 +0000 >Subject: [PATCH] Bug 22750: (24474: Add `onpayment` option to > `MarkLostItemsReturned`) > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../data/mysql/atomicupdate/bug_24474.perl | 28 +++++++++++++++++++ > installer/data/mysql/sysprefs.sql | 2 +- > 2 files changed, 29 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_24474.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_24474.perl b/installer/data/mysql/atomicupdate/bug_24474.perl >new file mode 100644 >index 0000000000..c964d0c829 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_24474.perl >@@ -0,0 +1,28 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if ( CheckVersion($DBversion) ) { >+ $dbh->do(q{ >+ UPDATE >+ systempreferences >+ SET >+ options = "batchmod|moredetail|cronjob|additem|pendingreserves|onpayment" >+ WHERE >+ variable = "MarkLostItemsAsReturned" >+ }); >+ >+ my $lost_item_returned = C4::Context->preference("MarkLostItemsAsReturned"); >+ my @set = split( ",", $lost_item_returned ); >+ push @set, 'onpayment'; >+ $lost_item_returned = join( ",", @set ); >+ >+ $dbh->do(qq{ >+ UPDATE >+ systempreferences >+ SET >+ value = "$lost_item_returned" >+ WHERE >+ variable = "MarkLostItemsAsReturned" >+ }); >+ >+ SetVersion($DBversion); >+ print "Upgrade to $DBversion done (Bug 24474 - Add `onpayment` option to MarkLostItemsAsReturned)\n"; >+} >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 1bbc5ea59b..105a76bac7 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -306,7 +306,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('MarcFieldForModifierName','',NULL,'Where to store the name of the record''s last modifier','Free'), > ('MarcFieldsToOrder','',NULL,'Set the mapping values for a new order line created from a MARC record in a staged file. In a YAML format.','textarea'), > ('MarcItemFieldsToOrder','',NULL,'Set the mapping values for new item records created from a MARC record in a staged file. In a YAML format.','textarea'), >-('MarkLostItemsAsReturned','batchmod,moredetail,cronjob,additem,pendingreserves','batchmod|moredetail|cronjob|additem|pendingreserves','Mark items as returned when flagged as lost','multiple'), >+('MarkLostItemsAsReturned','batchmod,moredetail,cronjob,additem,pendingreserves,onpayment','batchmod|moredetail|cronjob|additem|pendingreserves|onpayment','Mark items as returned when flagged as lost','multiple'), > ('MARCOrgCode','OSt','','Define MARC Organization Code for MARC21 records - http://www.loc.gov/marc/organizations/orgshome.html','free'), > ('MaxFine',NULL,'','Maximum fine a patron can have for all late returns at one moment. Single item caps are specified in the circulation rules matrix.','Integer'), > ('MaxItemsToDisplayForBatchDel','1000',NULL,'Display up to a given number of items in a single item deletionbatch.','Integer'), >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22750
:
111271
|
111272
|
111273
|
111274
|
111275
|
111276
|
111277
|
111278
|
111738
|
111739
|
111740
|
111741
|
111742
|
111743
|
111744
|
111745