Bugzilla – Attachment 111278 Details for
Bug 22750
Partial writeoff of lost fee causes item to be returned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22750: (24474: (QA follow-up) Fix failing test)
Bug-22750-24474-QA-follow-up-Fix-failing-test.patch (text/plain), 1.42 KB, created by
Martin Renvoize (ashimema)
on 2020-10-06 09:54:04 UTC
(
hide
)
Description:
Bug 22750: (24474: (QA follow-up) Fix failing test)
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-10-06 09:54:04 UTC
Size:
1.42 KB
patch
obsolete
>From dceca78e07661157b3b72994d04ea0744cf902b7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 31 Mar 2020 09:43:34 +0100 >Subject: [PATCH] Bug 22750: (24474: (QA follow-up) Fix failing test) > >The test was assuming default data and would fail if you ran through the >test plan (and disabled all but `onpayment` for the >'MarkLostItemsAsReturned' preference) on the data before running the >included unit tests. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Circulation.t | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 90d852d3bb..c7a6068b40 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -18,7 +18,7 @@ > use Modern::Perl; > use utf8; > >-use Test::More tests => 47; >+use Test::More tests => 48; > use Test::MockModule; > > use Data::Dumper; >@@ -2036,6 +2036,7 @@ subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub { > subtest 'AddReturn | is_overdue' => sub { > plan tests => 6; > >+ t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment'); > t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1); > t::lib::Mocks::mock_preference('finesMode', 'production'); > t::lib::Mocks::mock_preference('MaxFine', '100'); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22750
:
111271
|
111272
|
111273
|
111274
|
111275
|
111276
|
111277
|
111278
|
111738
|
111739
|
111740
|
111741
|
111742
|
111743
|
111744
|
111745