Attachment 111331 Details for Bug 26580 – Bug 26580: Remove unused C4::Acquisition::DelBasket function

[patch] Bug 26580: Remove unused C4::Acquisition::DelBasket function

Bug-26580-Remove-unused-C4AcquisitionDelBasket-fun.patch (text/plain), 1.85 KB, created by Martin Renvoize (ashimema) on 2020-10-07 13:26:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-10-07 13:26:20 UTC

Size: 1.85 KB

patch

obsolete

>From e65d049f0eb01146431f6d2634448a350027bd4a Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 30 Sep 2020 12:03:41 -0300
>Subject: [PATCH] Bug 26580: Remove unused C4::Acquisition::DelBasket function
>
>Bug 26577 removed the only use of it.
>
>To test:
>1. Apply this patch
>2. Run:
>   $ git grep DelBasket
>=> SUCCESS: Only finds references to DelBasketGroup
>3. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Acquisition.pm | 28 +---------------------------
> 1 file changed, 1 insertion(+), 27 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index 3aff14d667..504cb3fdaf 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -53,7 +53,7 @@ BEGIN {
>     require Exporter;
>     @ISA    = qw(Exporter);
>     @EXPORT = qw(
>-        &GetBasket &NewBasket &CloseBasket &ReopenBasket &DelBasket &ModBasket
>+        &GetBasket &NewBasket &CloseBasket &ReopenBasket &ModBasket
>         &GetBasketAsCSV &GetBasketGroupAsCSV
>         &GetBasketsByBookseller &GetBasketsByBasketgroup
>         &GetBasketsInfosByBookseller
>@@ -486,32 +486,6 @@ sub ReOpenBasketgroup {
> 
> #------------------------------------------------------------#
> 
>-
>-=head3 DelBasket
>-
>-  &DelBasket($basketno);
>-
>-Deletes the basket that has basketno field $basketno in the aqbasket table.
>-
>-=over
>-
>-=item C<$basketno> is the primary key of the basket in the aqbasket table.
>-
>-=back
>-
>-=cut
>-
>-sub DelBasket {
>-    my ( $basketno ) = @_;
>-    my $query = "DELETE FROM aqbasket WHERE basketno=?";
>-    my $dbh = C4::Context->dbh;
>-    my $sth = $dbh->prepare($query);
>-    $sth->execute($basketno);
>-    return;
>-}
>-
>-#------------------------------------------------------------#
>-
> =head3 ModBasket
> 
>   &ModBasket($basketinfo);
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26580: 110997 | 111043 | 111331