Attachment 111344 Details for Bug 25969 – Bug 26627: Print and confirming a hold can cause an infinite loop

[patch] Bug 26627: Print and confirming a hold can cause an infinite loop

Bug-26627-Print-and-confirming-a-hold-can-cause-an.patch (text/plain), 1.19 KB, created by Nick Clemens (kidclamp) on 2020-10-07 15:36:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-10-07 15:36:50 UTC

Size: 1.19 KB

patch

obsolete

>From 888b1cb0b1669ecdd6a31d3083cf17097691851e Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 7 Oct 2020 11:01:02 -0400
>Subject: [PATCH] Bug 26627: Print and confirming a hold can cause an infinite
> loop
>
>Test plan:
>1) Place a hold for pickup at library A
>2) Confirm the hold and print slip
>3) Checkin the item again
>4) Confirm the hold and print slip
>5) The modal returns, do it again
>6) Apply this patch
>7) Reload the page
>8) Repeat steps 1-3
>9) No loop!
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=25969
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index fefcc8f02e..cf440d2e30 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -1074,6 +1074,7 @@
> 
>             $('.print').on("click",function(e){
>                 this.form.print_slip.value = 1;
>+                this.form.barcode.remove();
>                 this.form.submit();
>             });
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25969: 106758 | 106771 | 107697 | 109678 | 109755 | 109756 | 110006 | 110007 | 111328 | 111344