Attachment 111352 Details for Bug 25898 – Bug 25898: (follow-up) POD

[patch] Bug 25898: (follow-up) POD

Bug-25898-follow-up-POD.patch (text/plain), 1.23 KB, created by Tomás Cohen Arazi (tcohen) on 2020-10-07 18:25:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-10-07 18:25:13 UTC

Size: 1.23 KB

patch

obsolete

>From 4bf58c18f0d9bcf9c01668bf782b5cfbfdae465f Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 7 Oct 2020 14:33:19 -0300
>Subject: [PATCH] Bug 25898: (follow-up) POD
>
>Our docs shouldn't suggest indirect object notation is accepted or
>encouraged.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/Auth.pm    | 2 +-
> C4/Context.pm | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index a114c60324a..94570e501bc 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -93,7 +93,7 @@ C4::Auth - Authenticates Koha users
>   use C4::Auth;
>   use C4::Output;
> 
>-  my $query = new CGI;
>+  my $query = CGI->new;
> 
>   my ($template, $borrowernumber, $cookie)
>     = get_template_and_user(
>diff --git a/C4/Context.pm b/C4/Context.pm
>index 58a6ad5e056..2dab73e9d1f 100644
>--- a/C4/Context.pm
>+++ b/C4/Context.pm
>@@ -211,8 +211,8 @@ sub import {
> 
> =head2 new
> 
>-  $context = new C4::Context;
>-  $context = new C4::Context("/path/to/koha-conf.xml");
>+  $context = C4::Context->new;
>+  $context = C4::Context->new("/path/to/koha-conf.xml");
> 
> Allocates a new context. Initializes the context from the specified
> file, which defaults to either the file given by the C<$KOHA_CONF>
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 25898: 106423 | 111351 | 111352 | 111588 | 111589 | 111714 | 112525