Attachment 111367 Details for Bug 26137 – [ALTERNATIVE PATCH] Bug 26137: Remove warnings from viewlog.pl

[patch] [ALTERNATIVE PATCH] Bug 26137: Remove warnings from viewlog.pl

Bug-26137-Remove-warnings-from-viewlogpl.patch (text/plain), 1.00 KB, created by Jonathan Druart on 2020-10-08 09:34:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-10-08 09:34:27 UTC

Size: 1.00 KB

patch

obsolete

>From adba587d228d25eeaaebab71766c4d0107f94d06 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 8 Oct 2020 11:33:23 +0200
>Subject: [PATCH] Bug 26137: Remove warnings from viewlog.pl
>
>The warnings are
>Use of uninitialized value $val in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 138.
>Problem = a value of  has been passed to param without key at /kohadevbox/koha/C4/Templates.pm line 138.
>---
> tools/viewlog.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/viewlog.pl b/tools/viewlog.pl
>index 9c2141eb2f..bf7d1d663b 100755
>--- a/tools/viewlog.pl
>+++ b/tools/viewlog.pl
>@@ -90,7 +90,7 @@ if ( $src eq 'circ' ) {
> $template->param(
>     debug => $debug,
>     C4::Search::enabled_staff_search_views,
>-    subscriptionsnumber => CountSubscriptionFromBiblionumber(scalar $input->param('object')),
>+    subscriptionsnumber => ( $object ? CountSubscriptionFromBiblionumber($object) : 0 ),
>     object => $object,
> );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26137: 107804 | 110936 | 110981 | 111073 | 111367 | 111390