Bugzilla – Attachment 111371 Details for
Bug 24598
Hold not reset properly if checked out to another patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24598: Remove warning from test
Bug-24598-Remove-warning-from-test.patch (text/plain), 1.05 KB, created by
Jonathan Druart
on 2020-10-08 10:04:19 UTC
(
hide
)
Description:
Bug 24598: Remove warning from test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-10-08 10:04:19 UTC
Size:
1.05 KB
patch
obsolete
>From d9a18a05d8f989818d039a6c1620d9c933b3570a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Oct 2020 12:03:48 +0200 >Subject: [PATCH] Bug 24598: Remove warning from test > >t/db_dependent/Koha/Items.t .. 6/12 Use of uninitialized value in string eq at /kohadevbox/koha/C4/Circulation.pm line 1460. >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index aa917a9e2d..2f91511dbd 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1457,7 +1457,7 @@ sub AddIssue { > comments => 'Forced branchtransfer' > } > )->store; >- if ( $transfer->reason eq 'Reserve' ) { >+ if ( $transfer->reason && $transfer->reason eq 'Reserve' ) { > my $hold = $item_object->holds->search( { found => 'T' } )->next; > if ( $hold ) { # Is this really needed? > $hold->set( { found => undef } )->store; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24598
:
108002
|
108003
|
110889
|
110890
|
111060
|
111061
| 111371