Attachment 111388 Details for Bug 26639 – Bug 26639: Add auto_savepoint to DBIC connection

[patch] Bug 26639: Add auto_savepoint to DBIC connection

Bug-26639-Add-autosavepoint-to-DBIC-connection.patch (text/plain), 1.09 KB, created by Jonathan Druart on 2020-10-09 10:01:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-10-09 10:01:19 UTC

Size: 1.09 KB

patch

obsolete

>From 9b4a805c6456b8220c5c3a2d5067c1fd5f4f63a5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 26 Oct 2018 11:17:40 -0300
>Subject: [PATCH] Bug 26639: Add auto_savepoint to DBIC connection
>
>See comment 0.
>
>https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints
>
>Otherwise:
>DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274
>
>Possible side-effects? Slowness?
>
>We need to push it to master ASAP and see how our test suite behave.
>---
> Koha/Database.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/Database.pm b/Koha/Database.pm
>index 55baf80537..f000a78494 100644
>--- a/Koha/Database.pm
>+++ b/Koha/Database.pm
>@@ -105,6 +105,7 @@ sub _new_schema {
>             PrintError => 1,
>             unsafe => !$RaiseError,
>             quote_names => 1,
>+            auto_savepoint => 1,
>             on_connect_do => [
>                 $encoding_query || (),
>                 $tz_query || (),
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26639: 111388 | 111392 | 111835