Bugzilla – Attachment 111394 Details for
Bug 23695
Items holdingbranch should be set to the originating library when generating a manual transfer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23695: (QA follow-up) Revert 'Orginating library' option
Bug-23695-QA-follow-up-Revert-Orginating-library-o.patch (text/plain), 3.37 KB, created by
Nick Clemens (kidclamp)
on 2020-10-09 10:44:20 UTC
(
hide
)
Description:
Bug 23695: (QA follow-up) Revert 'Orginating library' option
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-10-09 10:44:20 UTC
Size:
3.37 KB
patch
obsolete
>From 6983067fd9b78fb42b43512ee9726574be15fcc2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 9 Oct 2020 11:28:12 +0100 >Subject: [PATCH] Bug 23695: (QA follow-up) Revert 'Orginating library' option > >At my request, we added an 'Originating library' option to the manual >transfers form. > >However, we did not properly pass this through in the controller and I >have since discovered that my request was ill conceived/a >misunderstanding of requirements. > >This patch removes the option from the template and drops the references >to it in the controller. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > circ/branchtransfers.pl | 2 -- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 8 -------- > 2 files changed, 10 deletions(-) > >diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl >index f64d37fc76..ff59c03a5a 100755 >--- a/circ/branchtransfers.pl >+++ b/circ/branchtransfers.pl >@@ -79,7 +79,6 @@ my $setwaiting; > > my $request = $query->param('request') || ''; > my $borrowernumber = $query->param('borrowernumber') || 0; >-my $frombranchcd = $query->param('frombranchcd') || C4::Context->userenv->{'branch'}; > my $tobranchcd = $query->param('tobranchcd') || ''; > > my $ignoreRs = 0; >@@ -223,7 +222,6 @@ $template->param( > itemnumber => $itemnumber, > barcode => $barcode, > biblionumber => $biblionumber, >- frombranchcd => $frombranchcd, > tobranchcd => $tobranchcd, > reqmessage => $reqmessage, > cancelled => $cancelled, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >index c9ba832d7b..859f6ab8df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >@@ -72,7 +72,6 @@ > <input type="hidden" name="biblionumber" value="[% biblionumber | html %]" /> > <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" /> > <input type="hidden" name="tobranchcd" value="[% tobranchcd | html %]" /> >- <input type="hidden" name="frombranchcd" value="[% frombranchcd | html %]" /> > <input type="hidden" name="barcode" value="[% barcode | html %]" /> > <input type="hidden" name="request" value="KillReserved" /> > <input type="submit" value="Cancel" /> >@@ -152,13 +151,6 @@ > <fieldset class="brief"> > <legend>Transfer</legend> > <ol> >- <li> >- <label for="frombranchcd">Originating library: </label> >- <select name="frombranchcd" id="frombranchcd"> >- <option value="current_holding">Item's holding branch</option> >- [% PROCESS options_for_libraries libraries => Branches.all( selected => '', unfiltered => 1) %] >- </select> >- </li> > <li> > <label for="tobranchcd">Destination library: </label> > <select name="tobranchcd" id="tobranchcd"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23695
:
93231
|
98942
|
99955
|
99956
|
100567
|
100568
|
101441
|
101442
|
101443
|
107463
|
107464
|
107465
|
108183
|
108184
|
108185
|
108186
|
108273
|
108495
|
111391
| 111394