Attachment 111509 Details for Bug 12556 – Bug 12556: (follow-up) Fix failing test

[patch] Bug 12556: (follow-up) Fix failing test

Bug-12556-follow-up-Fix-failing-test.patch (text/plain), 1.17 KB, created by Joonas Kylmälä on 2020-10-12 10:58:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2020-10-12 10:58:03 UTC

Size: 1.17 KB

patch

obsolete

>From d89f0f406db07f10a2335fe53f344a6cfdff196c Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Mon, 12 Oct 2020 10:55:33 +0000
>Subject: [PATCH] Bug 12556: (follow-up) Fix failing test
>
>The method call set_waiting(1) was renamed to be set_transfer()
>---
> t/db_dependent/api/v1/holds.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t
>index 750bcd95b4..ff4f70ab1e 100755
>--- a/t/db_dependent/api/v1/holds.t
>+++ b/t/db_dependent/api/v1/holds.t
>@@ -471,10 +471,10 @@ subtest 'suspend and resume tests' => sub {
>       ->status_is( 400, 'Cannot suspend waiting hold' )
>       ->json_is( '/error', 'Found hold cannot be suspended. Status=W' );
> 
>-    $hold->set_waiting(1)->discard_changes;
>+    $hold->set_transfer->discard_changes;
> 
>     $t->post_ok( "//$userid:$password@/api/v1/holds/" . $hold->id . "/suspension" )
>-      ->status_is( 400, 'Cannot suspend waiting hold' )
>+      ->status_is( 400, 'Cannot suspend hold on transfer' )
>       ->json_is( '/error', 'Found hold cannot be suspended. Status=T' );
> 
>     $schema->storage->txn_rollback;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 12556: 107181 | 107182 | 107183 | 107184 | 107185 | 107186 | 108711 | 109140 | 109924 | 109925 | 109926 | 109927 | 109928 | 109929 | 110719 | 110942 | 110943 | 110944 | 110945 | 110946 | 110947 | 110948 | 110949 | 110950 | 110951 | 110952 | 110953 | 110954 | 110955 | 110956 | 110961 | 110962 | 110963 | 110964 | 110965 | 110966 | 111405 | 111406 | 111407 | 111408 | 111409 | 111410 | 111494 | 111495 | 111496 | 111497 | 111498 | 111499 | 111500 | 111509 | 111516 | 111585 | 111610