Attachment 111511 Details for Bug 26529 – Bug 26529: (follow-up) Remove warning

[patch] Bug 26529: (follow-up) Remove warning

Bug-26529-follow-up-Remove-warning.patch (text/plain), 978 bytes, created by Jonathan Druart on 2020-10-12 12:49:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-10-12 12:49:11 UTC

Size: 978 bytes

patch

obsolete

>From ce63afdeff34e99d251a2e5d7f33efdbfecb27b6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 12 Oct 2020 14:48:40 +0200
>Subject: [PATCH] Bug 26529: (follow-up) Remove warning
>
>---
> Koha/CirculationRules.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm
>index 743d8f1ab3..05850bee0f 100644
>--- a/Koha/CirculationRules.pm
>+++ b/Koha/CirculationRules.pm
>@@ -282,7 +282,7 @@ sub set_rule {
>     my $rule_name    = $params->{rule_name};
>     my $rule_value   = $params->{rule_value};
>     my $can_be_blank = defined $kind_info->{can_be_blank} ? $kind_info->{can_be_blank} : 1;
>-    $rule_value = undef if $rule_value && $rule_value eq "" && !$can_be_blank;
>+    $rule_value = undef if defined $rule_value && $rule_value eq "" && !$can_be_blank;
> 
>     for my $v ( $branchcode, $categorycode, $itemtype ) {
>         $v = undef if $v and $v eq '*';
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26529: 110686 | 110687 | 110695 | 110714 | 110715 | 110856 | 110857 | 110859 | 111251 | 111252 | 111253 | 111382 | 111471 | 111511