Attachment 111535 Details for Bug 26576 – Bug 26576: Subfield descriptions on authority detail view are cut off

[patch] Bug 26576: Subfield descriptions on authority detail view are cut off

Bug-26576-Subfield-descriptions-on-authority-detai.patch (text/plain), 6.74 KB, created by Katrin Fischer on 2020-10-13 11:34:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-10-13 11:34:09 UTC

Size: 6.74 KB

patch

obsolete

>From b94c19321c833c2e8e2732c9bfde7665c0464a0e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 30 Sep 2020 15:46:45 +0000
>Subject: [PATCH] Bug 26576: Subfield descriptions on authority detail view are
> cut off
>
>This patch corrects the authority detail view on the staff interface so
>that subfield descriptions are not longer output as truncated strings.
>
>For instance, before this patch the subfield description for 035$a would
>be "System control numbe"
>
>After the patch it should be "System control number."
>
>Based on the assumption that the subfield descriptions were truncated at
>some point for readability reasons I've also made some style changes
>intended to improve the readability of the page.
>
>To test, apply the patch and go to Authorities.
>
>- Search for and view the details for an authority.
>- On the authority detail page, confirm that subfield descriptions are
>  shown in full.
>- Confirm that the style changes look good and make the data more
>  readable.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/authorities/detail.tt          | 98 ++++++++++++++++------
> 1 file changed, 73 insertions(+), 25 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>index 2afd64247c..2670138b72 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>@@ -11,6 +11,45 @@
>     [% END %]
> </title>
> [% INCLUDE 'doc-head-close.inc' %]
>+[% Asset.css("css/addbiblio.css") | $raw %]
>+[% FILTER collapse %]
>+    <style>
>+        .marc_field {
>+            display: inline-block;
>+            padding: .3em;
>+            border-radius: 3px;
>+        }
>+        .marc_subfield {
>+            font-weight: bold;
>+            color: #666;
>+        }
>+        .marc_subfield_desc {
>+            color: #00698a;
>+            font-style: italic;
>+        }
>+        .auth_subfield {
>+            display: flex;
>+        }
>+        .tag {
>+            padding: .4em 0;
>+        }
>+        .tag_desc {
>+            color: #026;
>+        }
>+        .tag_num {
>+            color: #080;
>+        }
>+        .tag_title {
>+            font-size: 100%;
>+            font-weight: bold;
>+            padding: 0;
>+        }
>+        .ui-tabs-nav.ui-widget-header {
>+            border-bottom: 1px solid #b9d8d9;
>+            border-radius: 0;
>+        }
>+    </style>
>+[% END %]
> </head>
> 
> <body id="auth_detail" class="auth">
>@@ -64,35 +103,44 @@
>     [% FOREACH innerloo IN BIG_LOO.innerloop %]
>         [% IF ( innerloo.tag_number ) %]
>             <div class="tag">
>-            <div class="tag_title">
>-                <span class="tag_num">[% innerloo.tag_number | html %]</span>
>-                [% IF (innerloo.defined("ind1") ) %]
>-                    <span class="tag_ind1">[% innerloo.ind1 | html %]</span><span class="tag_ind2">[% innerloo.ind2 | html %]</span>
>-                [% END %]
>-                [% IF (innerloo.tag_desc) %]<span class="dashwrapper"> -</span> <span class="tag_desc">[% innerloo.tag_desc | html %]</span>[% END %]
>-            </div>
>+                <div class="tag_title">
>+                    <span class="tag_num marc_field">[% innerloo.tag_number | html %]</span>
>+                    [% IF (innerloo.defined("ind1") ) %]
>+                        <span class="tag_ind1">[% innerloo.ind1 | html %]</span><span class="tag_ind2">[% innerloo.ind2 | html %]</span>
>+                    [% END %]
>+                    [% IF (innerloo.tag_desc) %]
>+                        <span class="dashwrapper"> -</span> <span class="tag_desc marc_field">[% innerloo.tag_desc | html %]</span>
>+                    [% END %]
>+                </div>
>         [% ELSE %]
>             <div class="tag">
>         [% END %]
>         [% FOREACH subfiel IN innerloo.subfield %]
>-            <p>
>-                <label class="labelsubfield">&nbsp;
>-                [% UNLESS ( subfiel.hide_marc ) %]<strong>[% subfiel.marc_subfield | html %]</strong>[% END %]
>-                <span title="[% subfiel.long_desc | html %]" class="desc">[% subfiel.short_desc | html %]</span></label>
>-                [% IF ( subfiel.is_url ) %]
>-                    <a href="[% subfiel.marc_value | url %]">[% subfiel.marc_value | html %]</a>
>-                [% ELSE %]
>-                    [% subfiel.marc_value | html %]
>-                [% END %]
>-                [% IF ( subfiel.link ) %]
>-                    <a href="/cgi-bin/koha/catalogue/search.pl?op=do_search&amp;marclist=[% subfiel.link | uri %]&amp;operator==&amp;type=intranet&amp;value=[% subfiel.marc_value |url %]">
>-                        <img src="[% interface | html %]/[% theme | html %]/images/filefind.png" height="15" title="Search on [% subfiel.marc_value | html %]">
>-                    </a>
>-                [% END %]
>-                [% IF ( subfiel.authority ) %]
>-                    <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority | uri %]" class="button">Auth</a>
>-                [% END %]
>-            </p>
>+            <div class="auth_subfield">
>+                <div class="subfield_info marc_field">
>+                    [% UNLESS ( subfiel.hide_marc ) %]
>+                        <span class="marc_subfield">[% subfiel.marc_subfield | html %]</span>
>+                    [% END %]
>+                    <span class="marc_subfield_desc">[% subfiel.long_desc | html %]</span>
>+                </div> 
>+                <div class="subfield_content marc_field">
>+                    <span class="subfield_value">
>+                        [% IF ( subfiel.is_url ) %]
>+                            <a href="[% subfiel.marc_value | url %]">[% subfiel.marc_value | html %]</a>
>+                        [% ELSE %]
>+                            [% subfiel.marc_value | html %]
>+                        [% END %]
>+                    </span>
>+                    [% IF ( subfiel.link ) %]
>+                        <a href="/cgi-bin/koha/catalogue/search.pl?op=do_search&amp;marclist=[% subfiel.link | uri %]&amp;operator==&amp;type=intranet&amp;value=[% subfiel.marc_value |url %]">
>+                            <img src="[% interface | html %]/[% theme | html %]/images/filefind.png" height="15" title="Search on [% subfiel.marc_value | html %]">
>+                        </a>
>+                    [% END %]
>+                    [% IF ( subfiel.authority ) %]
>+                        <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority | uri %]" class="button">Auth</a>
>+                    [% END %]
>+                </div> 
>+            </div> 
>         [% END %]
>         </div>
>     [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26576: 111000 | 111044 | 111535