Attachment 111543 Details for Bug 24899 – Bug 26529: (follow-up) Remove warning

[patch] Bug 26529: (follow-up) Remove warning

Bug-26529-follow-up-Remove-warning.patch (text/plain), 1.14 KB, created by Katrin Fischer on 2020-10-13 12:14:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-10-13 12:14:50 UTC

Size: 1.14 KB

patch

obsolete

>From 7486130c0923a37b8952e836cad740fa19e51a29 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 12 Oct 2020 14:48:40 +0200
>Subject: [PATCH] Bug 26529: (follow-up) Remove warning
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>https://bugs.koha-community.org/show_bug.cgi?id=24899
>---
> Koha/CirculationRules.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm
>index 743d8f1ab3..05850bee0f 100644
>--- a/Koha/CirculationRules.pm
>+++ b/Koha/CirculationRules.pm
>@@ -282,7 +282,7 @@ sub set_rule {
>     my $rule_name    = $params->{rule_name};
>     my $rule_value   = $params->{rule_value};
>     my $can_be_blank = defined $kind_info->{can_be_blank} ? $kind_info->{can_be_blank} : 1;
>-    $rule_value = undef if $rule_value && $rule_value eq "" && !$can_be_blank;
>+    $rule_value = undef if defined $rule_value && $rule_value eq "" && !$can_be_blank;
> 
>     for my $v ( $branchcode, $categorycode, $itemtype ) {
>         $v = undef if $v and $v eq '*';
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24899: 106288 | 106289 | 111139 | 111140 | 111180 | 111181 | 111182 | 111543 | 111544 | 111545