Attachment 111562 Details for Bug 26655 – Bug 26655: Add ARIA Labels to OPAC Lists

[patch] Bug 26655: Add ARIA Labels to OPAC Lists

Bug-26655-Add-ARIA-Labels-to-OPAC-Lists.patch (text/plain), 2.41 KB, created by Katrin Fischer on 2020-10-13 13:25:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-10-13 13:25:33 UTC

Size: 2.41 KB

patch

obsolete

>From 7b864d644faa1f478fd1914d146dda067b0a8160 Mon Sep 17 00:00:00 2001
>From: Henry Bolshaw <bolshawh@parliament.uk>
>Date: Sat, 10 Oct 2020 00:24:36 +0000
>Subject: [PATCH] Bug 26655: Add ARIA Labels to OPAC Lists
>
>This patch adds ARIA labels to opac-shelves.tt
>so that checkboxes for list items are meaningful
>to users of screenreaders and other assistive
>technology.
>
>Test Plan:
>1/ Open an OPAC list
>2/ Inspect the checkbox for a list item
>3/ Confirm the aria-label is missing
>4/ Apply the patch
>5/ Refresh the Opac list page
>6/ Inspect the checkbox for a list item
>7/ Note that there is now an aria-label with a
>meaningful description
>8/Sign off
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index e28a9a26a4..bf42a7072f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -353,7 +353,12 @@
>                                         <tbody>
>                                             [% FOREACH itemsloo IN itemsloop %]
>                                                 <tr>
>-                                                    <td class="select selectcol"><input type="checkbox" class="cb" name="biblionumber" value="[% itemsloo.biblionumber | html %]" /></td>
>+                                                    [% IF ( itemsloo.title ) %]
>+                                                        [% check_title = itemsloo.title %]
>+                                                    [% ELSE %]
>+                                                        [% check_title = itemsloo.biblionumber %]
>+                                                    [% END %]
>+                                                    <td class="select selectcol"><input type="checkbox" class="cb" name="biblionumber" value="[% itemsloo.biblionumber | html %]" aria-label="[% check_title | html %]"/></td>
>                                                     [% UNLESS ( item_level_itypes ) %]
>                                                         <td>
>                                                             [% UNLESS ( Koha.Preference('OpacNoItemTypeImages') ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26655: 111441 | 111542 | 111562