Attachment 111574 Details for Bug 19382 – Bug 19382: (QA follow-up) Fix typos

[patch] Bug 19382: (QA follow-up) Fix typos

Bug-19382-QA-follow-up-Fix-typos.patch (text/plain), 3.04 KB, created by Kyle M Hall (khall) on 2020-10-13 17:44:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-10-13 17:44:17 UTC

Size: 3.04 KB

patch

obsolete

>From 1a7da883fbfd59bc7fff2a5ea68d68b2b77929c4 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 13 Oct 2020 13:42:58 -0400
>Subject: [PATCH] Bug 19382: (QA follow-up) Fix typos
>
>---
> C4/Circulation.pm    | 2 +-
> C4/SIP/ILS/Patron.pm | 2 +-
> circ/circulation.pl  | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 093b12eb1a..420bd286ed 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -857,7 +857,7 @@ sub CanBookBeIssued {
>     my $no_issues_charge_guarantors = C4::Context->preference("NoIssuesChargeGuarantorsWithGuarantees");
>     $no_issues_charge_guarantors = undef unless looks_like_number( $no_issues_charge_guarantors );
>     if ( defined $no_issues_charge_guarantors ) {
>-        my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guaranor => 0, include_this_patron => 1 });
>+        my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 });
> 
>         if ( $guarantors_non_issues_charges > $no_issues_charge_guarantors && !$inprocess && !$allowfineoverride) {
>             $issuingimpossible{DEBT_GUARANTORS} = $guarantors_non_issues_charges;
>diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm
>index 07e1a9b931..9820013ee7 100644
>--- a/C4/SIP/ILS/Patron.pm
>+++ b/C4/SIP/ILS/Patron.pm
>@@ -70,7 +70,7 @@ sub new {
>     my $fines_amount = $flags->{CHARGES}->{amount}; #TODO Replace with $patron->account->non_issues_charges
>     $fines_amount = ($fines_amount and $fines_amount > 0) ? $fines_amount : 0;
>     if ( C4::Context->preference('NoIssuesChargeGuarantorsWithGuarantees') ) {
>-        $fines_amount += $patron->relationships_debt({ include_guarantors => 1, only_this_guaranor => 0, include_this_patron => 1 });
>+        $fines_amount += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 });
>     } else {
>         my $guarantees_fines_amount = $flags->{CHARGES_GUARANTEES} ? $flags->{CHARGES_GUARANTEES}->{amount} : 0; #TODO: Replace with $patron->relationships_debt
>         $fines_amount += $guarantees_fines_amount;
>diff --git a/circ/circulation.pl b/circ/circulation.pl
>index e1391591f4..f6c0d20d15 100755
>--- a/circ/circulation.pl
>+++ b/circ/circulation.pl
>@@ -497,7 +497,7 @@ if ( $patron ) {
>     # Check the debt of this patrons guarantors *and* the guarantees of those guarantors
>     my $no_issues_charge_guarantors = C4::Context->preference("NoIssuesChargeGuarantorsWithGuarantees");
>     if ( $no_issues_charge_guarantors ) {
>-        my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guaranor => 0, include_this_patron => 1 });
>+        my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 });
> 
>         if ( $guarantors_non_issues_charges > $no_issues_charge_guarantors ) {
>             $template->param(
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 19382: 97234 | 97235 | 97303 | 99196 | 102090 | 106534 | 107344 | 109210 | 109211 | 109349 | 109357 | 109634 | 109635 | 109636 | 109841 | 109937 | 111570 | 111571 | 111572 | 111573 | 111574 | 111609