Bugzilla – Attachment 111658 Details for
Bug 26536
"Writeoff/Pay selected" deducts from old unpaid debts first
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26536: Fix incorrectly scoped variable
Bug-26536-Fix-incorrectly-scoped-variable.patch (text/plain), 1.27 KB, created by
Katrin Fischer
on 2020-10-14 23:21:54 UTC
(
hide
)
Description:
Bug 26536: Fix incorrectly scoped variable
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-10-14 23:21:54 UTC
Size:
1.27 KB
patch
obsolete
>From 1db1f24cbdd083ac63daff3cdfccd616fa2218fb Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 5 Oct 2020 09:08:24 +0100 >Subject: [PATCH] Bug 26536: Fix incorrectly scoped variable > >During work on bug 26076 a variable scope mistake was made when >reverting the logic to use distinct queries for selected accountlines. > >This patch restores the script scope of the varaible by removing the >superflous 'my' declaration. > >Test plan >1/ Add a set of manual invoices >2/ Select a subset of those manual invoices to 'Writeoff selected' >3/ Confirm that only those selected invoices have been written off. > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/paycollect.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/paycollect.pl b/members/paycollect.pl >index 471559202e..07b424111f 100755 >--- a/members/paycollect.pl >+++ b/members/paycollect.pl >@@ -150,7 +150,7 @@ if ( $selected_accts ) { > accountlines_id => { 'in' => \@acc }, > }; > >- my @selected_accountlines = Koha::Account::Lines->search( >+ @selected_accountlines = Koha::Account::Lines->search( > $search_params, > { order_by => 'date' } > ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26536
:
111209
|
111210
|
111211
|
111268
|
111269
|
111270
| 111658 |
111659
|
111660
|
111701
|
114508
|
114509
|
114510