Attachment 111685 Details for Bug 26534 – Bug 26687: Add color to Font Awesome icon for superlibrarian patrons

[patch] Bug 26687: Add color to Font Awesome icon for superlibrarian patrons

Bug-26687-Add-color-to-Font-Awesome-icon-for-super.patch (text/plain), 2.31 KB, created by Fridolin Somers on 2020-10-15 08:53:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2020-10-15 08:53:49 UTC

Size: 2.31 KB

patch

obsolete

>From 918113dac7024481b9049e3fc878979a64c879a8 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 15 Oct 2020 10:48:52 +0200
>Subject: [PATCH] Bug 26687: Add color to Font Awesome icon for superlibrarian
> patrons
>
>Bug 26534 adds a shield Font Awesome icon to help identify staff patrons.
>I propose to color this icon when patron is a superlibrarian.
>
>Patch adds 'is-superlibrarian' class that may be used for more CSS tuning.
>
>Test plan:
>1) Update staff CSS (yarn build)
>2) Compare display between a patron A beeing superlibarian and a patron B having only staff interface access
>3) Patron B has unchanged black shield icon
>4) Patron A has red shield icon
>5) Check a patron without permissions has no shield icon
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 6 ++++++
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 8 +++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index a698ec9bf9..bf7a023a63 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -1419,6 +1419,12 @@ dd {
>             background-color: #EEE;
>         }
>     }
>+
>+    &.is-superlibrarian {
>+        .fa.fa-shield {
>+            color: #CC0000;
>+        }
>+    }
> }
> 
> .patroninfo-section {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 17f8f36f11..7189171a2b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -3,7 +3,13 @@
> [% PROCESS 'member-display-address-style.inc' %]
> [% IF ( patron.borrowernumber ) %]
> [% SET patron_is_staff = patron.has_permission({ 'catalogue' => 1 }) %]
>-[% SET patron_type_class = patron_is_staff ? 'is-staff' : 'is-not-staff' %]
>+[% SET patron_is_superlibrarian = patron.is_superlibrarian %]
>+[% SET patron_type_class = 'is-not-staff' %]
>+[% IF ( patron_is_superlibrarian ) %]
>+    [% patron_type_class = 'is-staff is-superlibrarian' %]
>+[% ELSIF ( patron_is_staff ) %]
>+    [% patron_type_class = 'is-staff' %]
>+[% END %]
> <div class="patroninfo [% patron_type_class | html %]">
> 
> [% IF ( patronimages ) %]
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 26534: 110717 | 110718 | 110738 | 110739 | 110749 | 110750 | 110753 | 110754 | 110960 | 110972 | 110995 | 111185 | 111186 | 111187 | 111188 | 111189 | 111648 | 111649 | 111650 | 111651 | 111652 | 111685