Attachment 111729 Details for Bug 26439 – Bug 26439: (QA follow-up) Correct MSG instances in cart.js

[patch] Bug 26439: (QA follow-up) Correct MSG instances in cart.js

Bug-26439-QA-follow-up-Correct-MSG-instances-in-ca.patch (text/plain), 2.00 KB, created by Owen Leonard on 2020-10-15 13:11:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-10-15 13:11:45 UTC

Size: 2.00 KB

patch

obsolete

>From 96fc036abba882debb7b324cb5cfbaa855cf3446 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 15 Oct 2020 13:01:50 +0000
>Subject: [PATCH] Bug 26439: (QA follow-up) Correct MSG instances in cart.js
>
>To test, add some items to the cart in the staff interface and open the
>cart window. Test the "Selected items" links (Remove, add to list,
>etc.) without checking any checkboxes. You should get an alert, "No item
>was selected."
>---
> koha-tmpl/intranet-tmpl/prog/js/cart.js | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/cart.js b/koha-tmpl/intranet-tmpl/prog/js/cart.js
>index 4a1a71616f..b4212c0cdf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/cart.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/cart.js
>@@ -1,8 +1,9 @@
>+/* global __ dataTablesDefaults showMore showLess delSelRecords addSelToShelf sendBasket printBasket delBasket openBiblio selRecord */
> 
> function placeHold () {
>     var checkedItems = $("input:checkbox:checked");
>     if ($(checkedItems).size() === 0) {
>-        alert(MSG_NO_RECORD_SELECTED);
>+        alert( __("No item was selected") );
>         return false;
>     }
> 
>@@ -28,7 +29,7 @@ function placeHold () {
> function batchDelete(){
>     var checkedItems = $("input:checkbox:checked");
>     if ($(checkedItems).size() === 0) {
>-        alert(MSG_NO_RECORD_SELECTED);
>+        alert( __("No item was selected") );
>         return false;
>     }
>     var newloc;
>@@ -48,7 +49,7 @@ function batchDelete(){
> function batchModify(){
>     var checkedItems = $("input:checkbox:checked");
>     if ($(checkedItems).size() === 0) {
>-        alert(MSG_NO_RECORD_SELECTED);
>+        alert( __("No item was selected") );
>         return false;
>     }
>     var newloc;
>@@ -82,7 +83,7 @@ $(document).ready(function(){
>     });
> 
>     $(".holdsep").text("| ");
>-    $(".hold").text(_("Place hold"));
>+    $(".hold").text( __("Place hold") );
>     $("#downloadcartc").empty();
> 
>     $("#itemst").dataTable($.extend(true, {}, dataTablesDefaults, {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26439: 109969 | 110831 | 111636 | 111665 | 111729