Bugzilla – Attachment 111742 Details for
Bug 22750
Partial writeoff of lost fee causes item to be returned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22750: (24474: Filter out LOST_FOUND)
Bug-22750-24474-Filter-out-LOSTFOUND.patch (text/plain), 1.72 KB, created by
Nick Clemens (kidclamp)
on 2020-10-15 13:51:24 UTC
(
hide
)
Description:
Bug 22750: (24474: Filter out LOST_FOUND)
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-10-15 13:51:24 UTC
Size:
1.72 KB
patch
obsolete
>From d1f89858fbb9977584c6389ae893f1e1dac8ab1c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 5 Feb 2020 13:10:49 +0000 >Subject: [PATCH] Bug 22750: (24474: Filter out LOST_FOUND) > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/Account/Line.pm | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > >diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm >index 571c26a986..5fe4d8234a 100644 >--- a/Koha/Account/Line.pm >+++ b/Koha/Account/Line.pm >@@ -264,14 +264,22 @@ sub apply { > $debit->amountoutstanding( $owed - $amount_to_cancel )->store; > > # Same logic exists in Koha::Account::pay >- if ( $debit->amountoutstanding == 0 >- && $debit->itemnumber >+ if ( >+ C4::Context->preference('MarkLostItemsAsReturned') =~ >+ m|onpayment| > && $debit->debit_type_code >- && $debit->debit_type_code eq 'LOST' ) >+ && $debit->debit_type_code eq 'LOST' >+ && $debit->amountoutstanding == 0 >+ && $debit->itemnumber >+ && !( >+ $self->credit_type_code eq 'LOST_FOUND' >+ && $self->itemnumber == $debit->itemnumber >+ ) >+ ) > { >- C4::Circulation::ReturnLostItem( $self->borrowernumber, $debit->itemnumber ); >+ C4::Circulation::ReturnLostItem( $self->borrowernumber, >+ $debit->itemnumber ); > } >- > } > }); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22750
:
111271
|
111272
|
111273
|
111274
|
111275
|
111276
|
111277
|
111278
|
111738
|
111739
|
111740
|
111741
| 111742 |
111743
|
111744
|
111745