Bugzilla – Attachment 111772 Details for
Bug 22806
CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions
Bug-22806-follow-up-CanBookBeReserved-and-CanItemB.patch (text/plain), 1.55 KB, created by
Nick Clemens (kidclamp)
on 2020-10-15 16:45:25 UTC
(
hide
)
Description:
Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-10-15 16:45:25 UTC
Size:
1.55 KB
patch
obsolete
>From 4c190aa26e1ecfe41ce0e28ca95cff53441d7454 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 24 Jul 2019 11:33:48 +0000 >Subject: [PATCH] Bug 22806: (follow-up) CanBookBeReserved and > CanItemBeReserved must check AllowHoldsOnPatronsPossessions > >As CanBookBeReserved() was failing as $patron and and $biblio were not >instantiated I fixed that up. > >Test plan : >1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" >2 - Checkout an item to a borrower >3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. >4 - Cancel the hold and apply patch >5 - Repeat 3 -> Should not place hold and show error "NotHoldable" > >Sponsored-By: Catalyst IT >Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 8ad4e5178f..4827928c24 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -320,7 +320,7 @@ sub CanBookBeReserved{ > > # Check that patron have not checked out this biblio (if AllowHoldsOnPatronsPossessions set) > if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions') >- && C4::Circulation::CheckIfIssuedToPatron( $patron->borrowernumber, $biblio->biblionumber ) ) { >+ && C4::Circulation::CheckIfIssuedToPatron( $borrowernumber, $biblionumber ) ) { > return { status =>'itemAlreadyOnLoan' }; > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22806
:
89039
|
89724
|
91784
|
94388
|
94389
|
97947
|
99881
|
99882
|
99883
|
99884
|
99885
|
100091
|
100092
|
100093
|
100173
|
100174
|
100175
|
106564
|
106778
|
106779
|
106780
|
107760
|
107806
|
110100
|
110101
|
110102
|
110973
|
110974
|
110975
|
110976
|
111771
| 111772 |
111773
|
111774
|
112824