Attachment 111802 Details for Bug 23979 – Bug 23979: Move locked message to patron info section

[patch] Bug 23979: Move locked message to patron info section

Bug-23979-Move-locked-message-to-patron-info-secti.patch (text/plain), 2.87 KB, created by Katrin Fischer on 2020-10-15 21:13:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-10-15 21:13:33 UTC

Size: 2.87 KB

patch

obsolete

>From a88197d91e68bd3afc80a458c4180f24710fcb2b Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 6 Oct 2020 16:00:30 +0000
>Subject: [PATCH] Bug 23979: Move locked message to patron info section
>
>To test:
>1 - Set failed login attempts to some number
>2 - Attempt enough logins with a patront o lock them, or:
>    UPDATE borrowers SET login_attempts = 500 WHERE borrowernumber=5;
>3 - Attempt to checkout to borrower, no notice of lock
>4 - View patron details tab, see the locked message
>5 - Apply patch
>6 - Note the message is now in patron info and visible on all tabs for the member
>
>Signed-off-by: George Williams <george@nekls.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc        | 7 +++++++
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 7 -------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 17f8f36f11..c7e7a3585a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -104,6 +104,13 @@
>     <li class="patronlibrary">Home library: [% Branches.GetName( patron.branchcode ) | html %]</li>
>     <li class="patronborrowernumber">Borrowernumber: [% patron.borrowernumber | html %]</li>
>     <li><span class="patronupdatedon">Updated on [% patron.updated_on | $KohaDates with_hours => 1 %]</span></li>
>+    [% IF patron.account_locked %]
>+        [% IF patron.login_attempts < 0 %]
>+            <li class="blocker account_admin_locked">Account has been administratively locked.</li>
>+        [% ELSE %]
>+            <li class="blocker account_locked">Account has been locked.</li>
>+        [% END %]
>+    [% END %]
>   </ul></div>
> <div id="menu">
> <ul>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 4bf7ba95f7..615fda049a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -163,13 +163,6 @@
>                                         </li>
>                                     [% END %]
> 
>-                                    [% IF patron.account_locked %]
>-                                        [% IF patron.login_attempts < 0 %]
>-                                            <li class="blocker">Account has been administratively locked.</li>
>-                                        [% ELSE %]
>-                                            <li class="blocker">Account has been locked.</li>
>-                                        [% END %]
>-                                    [% END %]
>                                 </ul>
>                             </div>
>                         [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23979: 111316 | 111676 | 111802 | 112930