Attachment 111918 Details for Bug 26351 – Bug 26351: Add unit tests

[patch] Bug 26351: Add unit tests

Bug-26351-Add-unit-tests.patch (text/plain), 4.99 KB, created by Martin Renvoize (ashimema) on 2020-10-16 15:47:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-10-16 15:47:23 UTC

Size: 4.99 KB

patch

obsolete

>From 43a5ec598e61c9f189527082f7ab0242cffaef3f Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 28 Sep 2020 06:54:28 -0400
>Subject: [PATCH] Bug 26351: Add unit tests
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../Koha/Plugins/Barcode_transform_hooks.t    | 78 +++++++++++++++++++
> .../Plugins/Biblio_and_Items_plugin_hooks.t   |  3 +
> .../Koha/Plugins/Circulation_hooks.t          |  1 +
> t/lib/Koha/Plugin/Test.pm                     |  2 +-
> 4 files changed, 83 insertions(+), 1 deletion(-)
> create mode 100755 t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t
>
>diff --git a/t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t b/t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t
>new file mode 100755
>index 0000000000..9f5fa9eded
>--- /dev/null
>+++ b/t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t
>@@ -0,0 +1,78 @@
>+#!/usr/bin/perl
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it under the
>+# terms of the GNU General Public License as published by the Free Software
>+# Foundation; either version 3 of the License, or (at your option) any later
>+# version.
>+#
>+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License along
>+# with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Test::More tests => 4;
>+use Test::MockModule;
>+use Test::Warn;
>+
>+use File::Basename;
>+
>+use t::lib::Mocks;
>+use t::lib::TestBuilder;
>+
>+BEGIN {
>+    # Mock pluginsdir before loading Plugins module
>+    my $path = dirname(__FILE__) . '/../../../lib';
>+    t::lib::Mocks::mock_config( 'pluginsdir', $path );
>+
>+    use_ok('Koha::Plugins');
>+    use_ok('Koha::Plugins::Handler');
>+    use_ok('Koha::Plugin::Test');
>+}
>+
>+my $schema  = Koha::Database->new->schema;
>+my $builder = t::lib::TestBuilder->new;
>+
>+t::lib::Mocks::mock_config( 'enable_plugins', 1 );
>+
>+subtest '() hook tests' => sub {
>+
>+    plan tests => 1;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $plugins = Koha::Plugins->new;
>+    $plugins->InstallPlugins;
>+
>+    my $plugin = Koha::Plugin::Test->new->enable;
>+
>+    my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
>+
>+    t::lib::Mocks::mock_userenv(
>+        {
>+            patron     => $patron,
>+            branchcode => $patron->branchcode
>+        }
>+    );
>+
>+    # Avoid testing useless warnings
>+    my $test_plugin = Test::MockModule->new('Koha::Plugin::Test');
>+    $test_plugin->mock( 'after_item_action',   undef );
>+    $test_plugin->mock( 'after_biblio_action', undef );
>+
>+    my $biblio = $builder->build_sample_biblio();
>+    my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
>+    $item_1->barcode('THISISATEST');
>+
>+    warning_like { $item_1->store(); }
>+        qr/barcode_transform called with parameters: item, THISISATEST/,
>+        'AddReserve calls the after_hold_create hook';
>+
>+    $schema->storage->txn_rollback;
>+    Koha::Plugins::Methods->delete;
>+};
>diff --git a/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t b/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
>index 44f68ee87f..af49ef9563 100755
>--- a/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
>+++ b/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
>@@ -52,6 +52,9 @@ subtest 'after_biblio_action() and after_item_action() hooks tests' => sub {
> 
>     my $plugin = Koha::Plugin::Test->new->enable;
> 
>+    my $test_plugin = Test::MockModule->new('Koha::Plugin::Test');
>+    $test_plugin->mock( 'barcode_transform', undef );
>+
>     my $biblio_id;
> 
>     warning_like { ( $biblio_id, undef ) = C4::Biblio::AddBiblio( MARC::Record->new(), '' ); }
>diff --git a/t/db_dependent/Koha/Plugins/Circulation_hooks.t b/t/db_dependent/Koha/Plugins/Circulation_hooks.t
>index 5f8569d9ed..c7ca3030bf 100755
>--- a/t/db_dependent/Koha/Plugins/Circulation_hooks.t
>+++ b/t/db_dependent/Koha/Plugins/Circulation_hooks.t
>@@ -66,6 +66,7 @@ subtest 'after_circ_action() hook tests' => sub {
>     my $test_plugin = Test::MockModule->new('Koha::Plugin::Test');
>     $test_plugin->mock( 'after_item_action',   undef );
>     $test_plugin->mock( 'after_biblio_action', undef );
>+    $test_plugin->mock( 'barcode_transform', undef );
> 
>     my $biblio = $builder->build_sample_biblio();
>     my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
>diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm
>index a8cf2a5915..18767dc295 100644
>--- a/t/lib/Koha/Plugin/Test.pm
>+++ b/t/lib/Koha/Plugin/Test.pm
>@@ -95,7 +95,7 @@ sub intranet_js {
> 
> sub barcode_transform {
>     my ( $self, $type, $barcode ) = @_;
>-    return "Koha::Plugin::Test::barcode_transform";
>+    Koha::Exceptions::Exception->throw("barcode_transform called with parameters: $type, $barcode");
> }
> 
> sub barcode_generate {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26351: 109532 | 109548 | 109671 | 110844 | 110846 | 111575 | 111577 | 111578 | 111579 | 111862 | 111863 | 111894 | 111916 | 111917 | 111918 | 111919 | 111920 | 111921 | 111922 | 113571 | 113572 | 113573 | 113574 | 113575 | 113576 | 113577 | 113578 | 115172 | 115173 | 115174 | 115175 | 115176 | 115177 | 115178 | 115179 | 115180 | 118649 | 118650 | 118651 | 118652 | 118653 | 118654 | 118655 | 118656 | 118657 | 118658 | 118681 | 118682 | 118683 | 118684 | 118685 | 118686 | 118687 | 118688 | 118689 | 118690 | 122433 | 122434 | 122435 | 122436 | 122437 | 122438 | 122439 | 122440 | 122441 | 122442 | 124258 | 124259 | 124260 | 124261 | 124262 | 124263 | 124264 | 124265 | 124266 | 124313 | 125447 | 125763 | 125764 | 125765