Attachment 11193 Details for Bug 8518 – Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow

[patch] Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow

Bug-8518---Self-checkout-does-not-display-debt-amo.patch (text/plain), 1.79 KB, created by Mirko Tietgen on 2012-07-30 13:14:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mirko Tietgen

Created: 2012-07-30 13:14:14 UTC

Size: 1.79 KB

patch

obsolete

>From daafbee3921dbce2f163218d96a97e1a8989626b Mon Sep 17 00:00:00 2001
>From: Marc Veron <veron@veron.ch>
>Date: Sun, 29 Jul 2012 09:30:54 +0200
>Subject: [PATCH] Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow
>Content-Type: text/plain; charset="utf-8"
>
>If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message.
>
>Additionally, patch adds currency symbol to amount.
>
>Test plan:
>Do self checkout with patron who has debts that are over the limit.
>Test with and without preference 'AllowFineOverride' set.
>
>Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
>---
> opac/sco/sco-main.pl |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl
>index 243dddd..26a8774 100755
>--- a/opac/sco/sco-main.pl
>+++ b/opac/sco/sco-main.pl
>@@ -155,7 +155,7 @@ elsif ( $op eq "checkout" ) {
>             hide_main                 => 1,
>         );
>         if ($issue_error eq 'DEBT') {
>-            $template->param(amount => $impossible->{DEBT});
>+            $template->param(amount => C4::Budgets->GetCurrency()->{symbol}.$impossible->{DEBT});
>         }
>         #warn "issue_error: " . $issue_error ;
>         if ( $issue_error eq "NO_MORE_RENEWALS" ) {
>@@ -187,6 +187,9 @@ elsif ( $op eq "checkout" ) {
>             "circ_error_$issue_error" => 1,
>             hide_main                 => 1,
>         );
>+        if ($issue_error eq 'DEBT') {
>+            $template->param(amount => C4::Budgets->GetCurrency()->{symbol}.$needconfirm->{DEBT});
>+        }
>     } else {
>         if ( $confirmed || $issuenoconfirm ) {    # we'll want to call getpatroninfo again to get updated issues.
>             # warn "issuing book?";
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8518: 11182 | 11183 | 11192 | 11193