Bugzilla – Attachment 111948 Details for
Bug 26727
Fix <p/> appearing in the templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26727: Fix <p/> appearing in the templates
Bug-26727-Fix-p-appearing-in-the-templates.patch (text/plain), 5.10 KB, created by
Katrin Fischer
on 2020-10-18 16:36:30 UTC
(
hide
)
Description:
Bug 26727: Fix <p/> appearing in the templates
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-10-18 16:36:30 UTC
Size:
5.10 KB
patch
obsolete
>From dd2f225ee2f0e36f9e071fd8cf40bf6639b8baf4 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 18 Oct 2020 16:30:24 +0000 >Subject: [PATCH] Bug 26727: Fix <p/> appearing in the templates > >The self-closing p is not valid in HTML5: > >Error: Self-closing syntax (/>) used on a non-void HTML element. >Ignoring the slash and treating as a start tag. > >To test: > >1) >- Activate Article requests >- Search for a record to place an article request on in staff >- Look up the patron >- Verify the article request form looks ok >2) >- Search for a list of patrons >- Check 2 patrons and merge them using the button above the list >- Verify the distance between the button and the table looks ok >3) >- Create a new MARC modification template >- Create a new action >- Verify the distances between the first and second line of form > elements looks ok >4) >- Place a hold in staff >- Click on the Suspend link in the holds table (not below) >- Verify the modal looks ok >--- > .../intranet-tmpl/prog/en/modules/cataloguing/value_builder/EXAMPLE.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt | 2 +- > .../intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/EXAMPLE.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/EXAMPLE.tt >index 70064c887d..c2323f2c3b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/EXAMPLE.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/EXAMPLE.tt >@@ -10,7 +10,7 @@ > <p>Hi, you are looking at the result of launching the EXAMPLE plugin.</p> > <p>I received this from you:</p> > <input type="text" id="received" value="[% result | html %]" disabled /> >-<p/> >+</p> > <p>I will pass back what you type here, if you press OK.</p> > <input type="text" id="return" value="[% result | html %]" /> > <p> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >index de929cbc2f..dd26872ec2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >@@ -90,7 +90,7 @@ > > <fieldset class="rows"> > <legend>Place article request from [% biblio.title | html %] for [% patron.firstname | html %] [% patron.surname | html %] ( [% patron.cardnumber | html %] )</legend> >- <p/> >+ <p> > <ul> > <li> > <label for="title">Title:</label> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt >index 4d9680e479..0448127e46 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt >@@ -89,7 +89,7 @@ > <input type="hidden" name="id" value="[% p.id | html %]" /> > [% END %] > >- <p/> >+ <br> > > <input type="hidden" name="action" value="merge" /> > <input id="merge-patrons" type="submit" value="Merge patrons" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >index 73d0a59f4c..8fdf30cf8e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >@@ -220,7 +220,7 @@ > </span> > </span> > >- <p/> >+ <br><br> > > <select name="conditional" id="conditional" onchange="onConditionalChange(this);"> > <option value="" selected="selected" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 673494d3bf..3a4e129147 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -260,7 +260,7 @@ $(document).ready(function() { > <label for='suspend-modal-until'>" + __("Suspend until:") + "</label>\ > <input name='suspend_until' id='suspend-modal-until' class='suspend-until' size='10' />\ > \ >- <p/><a class='btn btn-link' id='suspend-modal-clear-date' >" + __("Clear date to suspend indefinitely") + "</a></p>\ >+ <p><a class='btn btn-link' id='suspend-modal-clear-date' >" + __("Clear date to suspend indefinitely") + "</a></p>\ > \ > </div>\ > \ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26727
:
111948
|
112761
|
112945
|
112961
|
112962
|
113110
|
113111