Attachment 111993 Details for Bug 26736 – Bug 26736: Compare values of reports log entries

[patch] Bug 26736: Compare values of reports log entries

Bug-26736-Compare-values-of-reports-log-entries.patch (text/plain), 3.74 KB, created by Owen Leonard on 2020-10-19 14:06:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-10-19 14:06:57 UTC

Size: 3.74 KB

patch

obsolete

>From abe2d60755bbd0d27840dadaaf7d2464f88fe750 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 19 Oct 2020 13:36:04 +0000
>Subject: [PATCH] Bug 26736: Compare values of reports log entries
>
>This patch adds the ability to compare the log entries for reports
>in the system log. The user can select two entries in the log search
>results and view a diff of the two versions.
>
>To test, apply the patch and check that the  ReportsLog system
>preference is enabled. If it isn't, enable it and make some changes to
>saved SQL reports so that you have log entries to test with.
>
>This is a trivial patch that simply adds "REPORTS" type log entries to
>the list of modules which can be selected for comparison. The full test
>plan is basically the same as that for Bug 26207:
>
>- Perform a search for log entries in the "Reports" module.
>- In the results, each entry for a report update should have a
>  "Compare" checkbox."
>- Check one of the checkboxes.
>- The table should now be filtered by the report title. This
>  facilitates meaningful selections for comparison.
>- You should see a message displayed onscreen, "Showing results
>  for...[report name]"
>- The "Check none" link in the toolbar above the table should now be
>  enabled.
>- If youy click the "Compare selected" link in the toolbar at this
>  stage you should get a message, "You must select two entries to
>  compare."
>- If you uncheck the checkbox the table should return to an unfiltered
>  state.
>- Check two checkboxes.
>- The "Compare selected" link in the toolbar should now be enabled.
>- Next to each of the checkboxes you checked should be a "View
>  comparison" link.
>- Clicking either of the "View comparison" links or the "Compare
>  selected" link should trigger a modal with the diff view of the two
>  reports log entries.
>- Try to select a third checkbox. You should get a message, "You can
>  select a maximum of two checkboxes." The box should remain unchecked.
>- Test that unchecking both checkboxes manually clears the table filter.
>- Test that the "Check none" link works to uncheck checked boxes and
>  clear the table filter.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>index 1a1f8fb18c..590f93810e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>@@ -315,7 +315,7 @@
>                                         [% IF ( loopro.module == 'CIRCULATION' ) %]
>                                             <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% loopro.info | uri %]&amp;biblionumber=[% loopro.biblionumber | uri %]&amp;bi=[% loopro.biblioitemnumber | uri %]#item[% loopro.info | uri %]" title="Display detail for this item">Item [% loopro.barcode | html %]</a>
>                                         [% ELSE %]
>-                                            [% IF loopro.module == "SYSTEMPREFERENCE" %]
>+                                            [% IF loopro.module == "SYSTEMPREFERENCE" || loopro.module == "REPORTS" %]
>                                                 <div class="loginfo" id="loginfo[% loopro.action_id | html %]">[% loopro.info | trim | html %]</div>
>                                                 <div class="compare_info" id="compare_info[% loopro.action_id | html %]">
>                                                     <label><input type="checkbox" name="diff" id="action_id[% loopro.action_id | html %]" data-actionid="[% loopro.action_id | html %]" data-filter="[% FOREACH info IN loopro.info.split(' \| ') %][% IF loop.first %][% info | html %][% END %][% END %]" class="compare" /> Compare</label>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26736: 111993 | 111998 | 112038