Bugzilla – Attachment 11200 Details for
Bug 8408
Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank
SIGNED-OFF-Bug-8408---Odd-OPAC-message-when-OPAC-R.patch (text/plain), 2.79 KB, created by
Owen Leonard
on 2012-07-30 15:26:35 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-07-30 15:26:35 UTC
Size:
2.79 KB
patch
obsolete
>From 453e70d85bfa523138240c7e4bfa9e2906ad9802 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 10 Jul 2012 10:57:46 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 8408 - Odd OPAC message when OPAC Renewals > are disabled and OPACFineNoRenewals is set to blank >Content-Type: text/plain; charset="utf-8" > >If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). >A user who owes any fines, when logged in to the OPAC will receive the following message: > > Please note: You have more than 0.00 in fines. > >This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether. > >This patch modifies the message to the following: > > Please note: You currently owe $fines in fines > >where $fines in the formatted amount the borrower currently owes >in fines. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 2 +- > opac/opac-user.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >index 33e3b48..26b5efc 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >@@ -103,7 +103,7 @@ $.tablesorter.addParser({ > [% IF ( renewal_blocked_fines ) && ( OpacRenewalAllowed ) %] > <span id="renewal_blocked_fines"><li><strong>Please note: </strong> Since you have <a href="/cgi-bin/koha/opac-account.pl">more than <span id="renewal_blocked_fines_amount">[% renewal_blocked_fines %]</span></a> in fines, you cannot renew your books online. Please pay your fines if you wish to renew your books.</li></span> > [% ELSIF ( renewal_blocked_fines ) %] >- <span id="renewal_blocked_fines"><li><strong>Please note: </strong> You have <a href="/cgi-bin/koha/opac-account.pl">more than <span id="renewal_blocked_fines_amount">[% renewal_blocked_fines %]</span></a> in fines. </li></span> >+ <span id="renewal_blocked_fines"><li><strong>Please note: </strong> You currently owe <a href="/cgi-bin/koha/opac-account.pl"><span id="renewal_blocked_fines_amount">[% renewal_blocked_fines %] in fines.</span></a></li></span> > [% END %] > </ul></div> > [% END %] >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index 4dbc432..50a167e 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -109,7 +109,7 @@ if ( $borr->{amountoutstanding} > $no_renewal_amt ) { > $borr->{'flagged'} = 1; > $canrenew = 0; > $template->param( >- renewal_blocked_fines => sprintf( '%.02f', $no_renewal_amt ), >+ renewal_blocked_fines => sprintf( '%.02f', $borr->{amountoutstanding} ), > ); > } > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8408
:
10750
|
11200
|
11323
|
11324
|
11555
|
11556