Bugzilla – Attachment 112017 Details for
Bug 24370
Editing purchase suggestion changes the acquisition library to logged-in user's
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24370: Don't reset library when editing a suggestion
Bug-24370-Dont-reset-library-when-editing-a-sugges.patch (text/plain), 2.08 KB, created by
Séverine Queune
on 2020-10-20 06:47:05 UTC
(
hide
)
Description:
Bug 24370: Don't reset library when editing a suggestion
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2020-10-20 06:47:05 UTC
Size:
2.08 KB
patch
obsolete
>From d8672c564b9b198b3e5a7278ee7723b4169b87a6 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 5 Oct 2020 17:23:31 +0000 >Subject: [PATCH] Bug 24370: Don't reset library when editing a suggestion >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When editing a suggestion, the library will be reset to the currently >logged in librarian's homebranch, no matter what the libray was before. > >This fixes this, the library selection will remain at the db value when >edited. > >To test: >- Create a suggestion with Any library. >- Edit the suggestion - it will show your homebranch as library >- Change to any library but your homebranch >- The summary should show the correct value after saving >- Edit the suggestoin again - it's set back to your homebranch again >- Apply patch >- Repeat the steps, the pull down should now show the correct library > at all times. > >Caveat: I think there is a somewhat separate issue/bug in that once a library >was saved, you cannot switch back to "Any". I haven't been able to fix this and >suggest to maybe file a separate bug. > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 5c5cf9a..41f5ba7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -442,7 +442,7 @@ > <li><label for="branchcode">Library:</label> > <select name="branchcode" id="branchcode"> > <option value="">Any</option> >- [% PROCESS options_for_libraries libraries => Branches.all( selected => branchfilter || branchcode ) %] >+ [% PROCESS options_for_libraries libraries => Branches.all( selected => branchcode ) %] > </select> > </li> > <li><label for="budgetid">Fund:</label> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24370
:
111821
|
112017
|
112044
|
112071
|
112072
|
112073
|
124085
|
125866
|
125867
|
125868
|
127181
|
127182
|
127183