Attachment 112029 Details for Bug 26749 – Bug 26749: Correct dropdown markup in OPAC cart

[patch] Bug 26749: Correct dropdown markup in OPAC cart

Bug-26749-Correct-dropdown-markup-in-OPAC-cart.patch (text/plain), 3.79 KB, created by Owen Leonard on 2020-10-20 12:04:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-10-20 12:04:43 UTC

Size: 3.79 KB

patch

obsolete

>From c9857eddc66187f047f4ece76ca28b0b8bab6f9b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 20 Oct 2020 11:58:49 +0000
>Subject: [PATCH] Bug 26749: Correct dropdown markup in OPAC cart
>
>This patch corrects the markup of the "Download" dropdown menu in the
>OPAc cart. It was not updated during the upgrade to Bootstrap 4.
>
>To test, apply the patch and perform a catalog search in the OPAC.
>
>- Add some titles to the cart.
>- Open the cart and test the "Download" menu button.
>- The menu should display correctly, and the menu items should work to
>  download the correct files.
>---
> .../opac-tmpl/bootstrap/en/modules/opac-basket.tt      | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>index e81d2b0cd5..c3c12ee36f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>@@ -29,18 +29,16 @@
>                                 [% END %]
> 
>                                 <div id="download-cart" class="btn-group dropdown">
>-                                    <a id="format" class="btn btn-link dropdown-toggle" data-toggle="dropdown" href="#"><i class="fa fa-fw fa-download" aria-hidden="true"></i> Download <b class="caret"></b></a>
>-                                    <ul class="dropdown-menu pull-left" role="menu" aria-labelledby="format">
>-                                        <li><a role="menuitem" class="download-cart" data-format="bibtex" href="#">BibTeX</a></li>
>-                                        <li><a role="menuitem" class="download-cart" data-format="isbd" href="#">ISBD</a></li>
>-                                        <li><a role="menuitem" class="download-cart" data-format="iso2709" href="#">MARC</a></li>
>-                                        <li><a role="menuitem" class="download-cart" data-format="ris" href="#">RIS (Zotero, EndNote, others)</a></li>
>+                                    <a id="format" class="btn btn-link dropdown-toggle" data-toggle="dropdown" role="button" href="#"><i class="fa fa-fw fa-download" aria-hidden="true"></i> Download <b class="caret"></b></a>
>+                                    <div class="dropdown-menu" role="menu" aria-labelledby="format">
>+                                        <a role="menuitem" class="dropdown-item download-cart" data-format="bibtex" href="#">BibTeX</a>
>+                                        <a role="menuitem" class="dropdown-item download-cart" data-format="isbd" href="#">ISBD</a>
>+                                        <a role="menuitem" class="dropdown-item download-cart" data-format="iso2709" href="#">MARC</a>
>+                                        <a role="menuitem" class="dropdown-item download-cart" data-format="ris" href="#">RIS (Zotero, EndNote, others)</a>
>                                         [% FOREACH csv_profile IN csv_profiles %]
>-                                            <li>
>-                                                <a role="menuitem" class="download-cart" data-format="[% csv_profile.export_format_id | html %]" href="#">CSV - [% csv_profile.profile | html %]</a>
>-                                            </li>
>+                                            <a role="menuitem" class="dropdown-item download-cart" data-format="[% csv_profile.export_format_id | html %]" href="#">CSV - [% csv_profile.profile | html %]</a>
>                                         [% END %]
>-                                    </ul>
>+                                    </div>
>                                 </div>
> 
>                                 <a class="btn btn-link remove empty" href="opac-basket.pl"><i class="fa fa-fw fa-trash" aria-hidden="true"></i> Empty and close</a>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26749: 112029 | 112198 | 112221