Attachment 112039 Details for Bug 21898 – Bug 21898: Add aqbasket to available tables for AQORDER

[patch] Bug 21898: Add aqbasket to available tables for AQORDER

Bug-21898-Add-aqbasket-to-available-tables-for-AQO.patch (text/plain), 2.44 KB, created by Katrin Fischer on 2020-10-20 13:36:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-10-20 13:36:48 UTC

Size: 2.44 KB

patch

obsolete

>From 0dbf6f6d356bfb8e5ae4b4be359de863383a0f3b Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 1 Oct 2020 09:04:43 +0100
>Subject: [PATCH] Bug 21898: Add aqbasket to available tables for AQORDER
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch should allow <<aqbasket.$field>> replacements to work in both
>email subject and email content fields for notices.
>
>Test plan
>1/ Add <<aqbasket.basketname>> into the AQORDER notice (In the subject
>line and content box)
>2/ Trigger said notice to send (before applying the patch)
>3/ Note that the replacements have not taken place..
><<aqbasket.basketname>> is present as is.
>4/ Apply patch
>5/ Trigger the notice again
>6/ Note that the replacements are now made.
>7/ Signoff
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Letters.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 2bae52d346..710706d3db 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -469,9 +469,10 @@ sub SendAlerts {
>             letter_code => $letter_code,
>             branchcode => $userenv->{branch},
>             tables => {
>-                'branches'    => $userenv->{branch},
>+                'branches'      => $userenv->{branch},
>                 'aqbooksellers' => $databookseller,
>                 'aqcontacts'    => $datacontact,
>+                'aqbasket'     => $externalid,
>             },
>             repeat => $dataorders,
>             want_librarian => 1,
>@@ -762,6 +763,7 @@ sub _parseletter_sth {
>     ($table eq 'suggestions'  )    ? "SELECT * FROM $table WHERE   suggestionid = ?"                                  :
>     ($table eq 'aqbooksellers')    ? "SELECT * FROM $table WHERE             id = ?"                                  :
>     ($table eq 'aqorders'     )    ? "SELECT * FROM $table WHERE    ordernumber = ?"                                  :
>+    ($table eq 'aqbasket'     )    ? "SELECT * FROM $table WHERE       basketno = ?"                                  :
>     ($table eq 'opac_news'    )    ? "SELECT * FROM $table WHERE          idnew = ?"                                  :
>     ($table eq 'article_requests') ? "SELECT * FROM $table WHERE             id = ?"                                  :
>     ($table eq 'borrower_modifications') ? "SELECT * FROM $table WHERE verification_token = ?" :
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21898: 111024 | 111025 | 112027 | 112039 | 112979 | 112980