Bugzilla – Attachment 112072 Details for
Bug 24370
Editing purchase suggestion changes the acquisition library to logged-in user's
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24370: (follow-up) Allow resetting library to ANY
Bug-24370-follow-up-Allow-resetting-library-to-ANY.patch (text/plain), 1.00 KB, created by
Nick Clemens (kidclamp)
on 2020-10-20 18:25:12 UTC
(
hide
)
Description:
Bug 24370: (follow-up) Allow resetting library to ANY
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-10-20 18:25:12 UTC
Size:
1.00 KB
patch
obsolete
>From 61124c450f0a905a459afc26d3dcac0b3b4d3d01 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 20 Oct 2020 15:50:30 +0100 >Subject: [PATCH] Bug 24370: (follow-up) Allow resetting library to ANY > >This patch updates ModSuggestion to reset branchcode to null if passed >an empty string. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Suggestions.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm >index 11cbf96fb7..2d0e985510 100644 >--- a/C4/Suggestions.pm >+++ b/C4/Suggestions.pm >@@ -471,6 +471,7 @@ sub ModSuggestion { > return unless( $suggestion and defined($suggestion->{suggestionid}) ); > > my $suggestion_object = Koha::Suggestions->find( $suggestion->{suggestionid} ); >+ $suggestion->{branchcode} = undef if ( exists( $suggestion->{branchcode} ) && $suggestion->{branchcode} eq "" ); > eval { # FIXME Must raise an exception instead > $suggestion_object->set($suggestion)->store; > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24370
:
111821
|
112017
|
112044
|
112071
|
112072
|
112073
|
124085
|
125866
|
125867
|
125868
|
127181
|
127182
|
127183