Bugzilla – Attachment 112073 Details for
Bug 24370
Editing purchase suggestion changes the acquisition library to logged-in user's
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24370: (QA follow-up) Make new suggestions default to the library you re viewing
Bug-24370-QA-follow-up-Make-new-suggestions-defaul.patch (text/plain), 1.75 KB, created by
Nick Clemens (kidclamp)
on 2020-10-20 18:25:20 UTC
(
hide
)
Description:
Bug 24370: (QA follow-up) Make new suggestions default to the library you re viewing
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-10-20 18:25:20 UTC
Size:
1.75 KB
patch
obsolete
>From 9f1cd81509b133c79e573f58ce7f7495d15162b8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 20 Oct 2020 18:19:46 +0000 >Subject: [PATCH] Bug 24370: (QA follow-up) Make new suggestions default to the > library you re viewing > >It looks like this problem was caused by code from bug 25033, we were attempting to have the >dropdown either be the current branch filter, or the suggestion's branch code, but the variables here are confusing and it didn't work > >This explicitly sets the branchcode when creating a new suggestion to allow fixing current behaviour and >show the correct value when creating new > >To test: >1 - Be signed in as branch A >2 - Browse to suggestions and limit to branch "Any" >3 - Click 'New suggestion" >4 - Defaults to Any >5 - Cancel and limit to branch B >6 - New suggestion defaults to branch B > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 41f5ba7b76..a4f3c31abc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -512,7 +512,7 @@ > > [% IF op == 'else' %] > <div id="toolbar" class="btn-toolbar"> >- <a class="btn btn-default" id="newsuggestion" href="suggestion.pl?op=add"><i class="fa fa-plus"></i> New purchase suggestion</a> >+ <a class="btn btn-default" id="newsuggestion" href="suggestion.pl?op=add&branchcode=[% branchcode | uri %]"><i class="fa fa-plus"></i> New purchase suggestion</a> > </div> > > <h1>Suggestions management</h1> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24370
:
111821
|
112017
|
112044
|
112071
|
112072
|
112073
|
124085
|
125866
|
125867
|
125868
|
127181
|
127182
|
127183