Bugzilla – Attachment 11208 Details for
Bug 8268
Koha should offer way to backup entire db
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8268: improve error checking
Bug-8268-improve-error-checking.patch (text/plain), 1.10 KB, created by
Jared Camins-Esakov
on 2012-07-30 18:11:57 UTC
(
hide
)
Description:
Bug 8268: improve error checking
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-07-30 18:11:57 UTC
Size:
1.10 KB
patch
obsolete
>From f2009099500ce677dc1efd6324aeba9e7eafa637 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Mon, 30 Jul 2012 14:09:25 -0400 >Subject: [PATCH] Bug 8268: improve error checking >Content-Type: text/plain; charset="UTF-8" > >Valid download attempts were being denied thanks to an incorrect >regular expression. This patch fixes that, and makes it easier to >understand what's going on in the code. >--- > tools/export.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/tools/export.pl b/tools/export.pl >index af358e6..a62adf7 100755 >--- a/tools/export.pl >+++ b/tools/export.pl >@@ -345,7 +345,8 @@ sub download_backup { > my $filename = $args->{filename}; > > return unless ( $directory && -d $directory ); >- return unless ( $filename =~ m/$extension(\.(gz|bz2|xz))?$/ && not $filename =~ m#|# ); >+ return unless ( $filename =~ m/\.$extension(\.(gz|bz2|xz))?$/ ); >+ return if ( $filename =~ m#/# ); > $filename = "$directory/$filename"; > return unless ( -f $filename && -o $filename ); > return unless ( open(my $dump, '<', $filename) ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8268
:
10358
|
10471
|
10682
|
10749
|
10751
|
10869
|
11178
|
11187
|
11208
|
11262