Bugzilla – Attachment 112094 Details for
Bug 26762
OPAC hold template markup error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26762: Modify template logic in opac-reserves.tt to avoid error
Bug-26762-Modify-template-logic-in-opac-reservestt.patch (text/plain), 2.27 KB, created by
Owen Leonard
on 2020-10-21 11:59:31 UTC
(
hide
)
Description:
Bug 26762: Modify template logic in opac-reserves.tt to avoid error
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-10-21 11:59:31 UTC
Size:
2.27 KB
patch
obsolete
>From 0e7e47ed449d99fae31239dc20b93ef2ee8da3d3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 21 Oct 2020 11:57:26 +0000 >Subject: [PATCH] Bug 26762: Modify template logic in opac-reserves.tt to avoid > error > >This patch makes a change to the OPAC hold template to prevent certain >cases where the output is invalid. > >To reproduce, perform a search in the OPAC which will return some titles >which can be placed on hold and some which cannot. > > - Select all results (some holdable, some not) > - Click the "Place hold" link > - On the "Confirm holds" page the layout will be broken after the > first instance of the message "There are no items that can be placed > on hold." > >To test, apply the patch and repeat the process above. After the patch >has been applied the "confirm holds" page should look correct. >Validating the HTML source should return no errors. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 1b9dd3bdee..87a90cf6a6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -164,7 +164,6 @@ > <div id="bigloop"> > > [% FOREACH bibitemloo IN bibitemloop %] >- [% IF ( bibitemloo.holdable ) %] > <div class="holdrow"> > [% IF bibitemloo.forced_hold_level %] > <span class="forced_hold_level"><h3> >@@ -178,6 +177,7 @@ > </h3></span> > [% END %] > <p> >+ [% IF ( bibitemloo.holdable ) %] > <input class="reserve_mode" name="reserve_mode" type="hidden" value="single"/> > <input class="single_bib" name="single_bib" type="hidden" value="[% bibitemloo.biblionumber | html %]"/> > <span class="confirmjs_hold" title="[% bibitemloo.biblionumber | html %]" style="padding:.3em"></span> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26762
:
112094
|
112392
|
112394
|
112439