Attachment 112114 Details for Bug 26766 – Bug 26766: Correct selection of title during OPAC note confirmation

[patch] Bug 26766: Correct selection of title during OPAC note confirmation

Bug-26766-Correct-selection-of-title-during-OPAC-n.patch (text/plain), 1.91 KB, created by Owen Leonard on 2020-10-21 17:30:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-10-21 17:30:23 UTC

Size: 1.91 KB

patch

obsolete

>From 55159592b10e44aeedd284bec04a696789ae60be Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 21 Oct 2020 17:15:30 +0000
>Subject: [PATCH] Bug 26766: Correct selection of title during OPAC note
> confirmation
>
>This patch modifies the JavaScript in opac-user.tt which executes when
>the user submits a checkout note. The script tries to grab the
>checkout's title from an earlier cell in the table row so that it can
>display it in the confirmation message.
>
>Before start ratings were enabled on this page, the title of each
>checked-out item was the only HTML inside this table cell, so it was
>necessary only to grab the HTML contents of the <td>. Now that star
>ratings might be displayed as well we must make the selection more
>specific.
>
>To test, apply the patch and enable both the  OpacStarRatings and
>AllowCheckoutNotes preferences.
>
> - Log in to the OPAC as a user with checkouts.
> - On the "Your summary" page, fill out and submit the "Note" field for
>   one of your checkouts.
> - In the confirmation message, confirm that the correct title
>   information is displayed as a link to the bibliographic detail page.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 90c0c78220..a383c35f1d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -921,7 +921,7 @@
> 
>                 $(".js_submitnote").click(function(e){
>                     var $self = $(this);
>-                    var title = $(this).parent().siblings('.title').html();
>+                    var title = $(this).parent().parent().find('a.title')[0].outerHTML;
>                     var $noteinput = $(this).siblings('input[name="note"]').first();
> 
>                     var ajaxData = {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26766: 112114 | 112445 | 112447