Attachment 112206 Details for Bug 24412 – Bug 24412: (follow-up) tests

[patch] Bug 24412: (follow-up) tests

Bug-24412-follow-up-tests.patch (text/plain), 2.22 KB, created by Séverine Queune on 2020-10-22 16:30:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Séverine Queune

Created: 2020-10-22 16:30:36 UTC

Size: 2.22 KB

patch

obsolete

>From f33241d0239cf765e99f671f86f8693f184aca6e Mon Sep 17 00:00:00 2001
>From: Nicolas Legrand <nicolas.legrand@bulac.fr>
>Date: Wed, 21 Oct 2020 12:10:19 +0200
>Subject: [PATCH] Bug 24412: (follow-up) tests
>
>Add some test for Koha::Hold->desk and Koha::Hold->set_waiting.
>
>Test plan:
>
>    1. prove t/db_dependent/Koha/Holds.t
>    2. should be green!
>---
> t/db_dependent/Koha/Holds.t | 42 +++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 41 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Holds.t b/t/db_dependent/Koha/Holds.t
>index 2282290..cc61fc0 100755
>--- a/t/db_dependent/Koha/Holds.t
>+++ b/t/db_dependent/Koha/Holds.t
>@@ -19,7 +19,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 4;
>+use Test::More tests => 5;
> use Test::Warn;
> 
> use C4::Reserves;
>@@ -368,6 +368,46 @@ subtest 'cancel all with reason' => sub {
>     $message->delete;
> };
> 
>+subtest 'Desks' => sub {
>+    plan tests => 5;
>+    my $library = $builder->build_object( { class => 'Koha::Libraries' } );
>+
>+    my $desk = Koha::Desk->new({
>+	desk_name  => 'my_desk_name_for_test',
>+	branchcode => $library->branchcode ,
>+			       })->store;
>+    ok($desk, "Desk created");
>+    my $item = $builder->build_sample_item({ library => $library->branchcode });
>+    my $manager = $builder->build_object( { class => "Koha::Patrons" } );
>+    t::lib::Mocks::mock_userenv( { patron => $manager, branchcode => $manager->branchcode } );
>+
>+    my $patron = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { branchcode => $library->branchcode, }
>+        }
>+	);
>+
>+    my $reserve_id = C4::Reserves::AddReserve(
>+        {
>+            branchcode     => $library->branchcode,
>+            borrowernumber => $patron->borrowernumber,
>+            biblionumber   => $item->biblionumber,
>+            priority       => 1,
>+            itemnumber     => $item->itemnumber,
>+        }
>+    );
>+
>+    my $hold = Koha::Holds->find($reserve_id);
>+
>+    ok($reserve_id, "Hold created");
>+    ok($hold, "Hold found");
>+    $hold->set_waiting($desk->desk_id);
>+    is($hold->found, 'W', 'Hold is waiting with correct status set');
>+    is($hold->desk_id, $desk->desk_id, 'Hold is attach to its desk');
>+
>+};
>+
> $schema->storage->txn_rollback;
> 
> 1;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 24412: 97328 | 97329 | 97330 | 101625 | 101626 | 101627 | 101628 | 101629 | 101630 | 101721 | 101722 | 101723 | 101825 | 101884 | 101885 | 101886 | 101898 | 101899 | 101900 | 101955 | 101956 | 101957 | 106586 | 106648 | 110067 | 110068 | 110069 | 110070 | 110450 | 110451 | 110452 | 110453 | 110454 | 110455 | 110582 | 110583 | 110584 | 110585 | 110586 | 112046 | 112047 | 112048 | 112049 | 112050 | 112092 | 112099 | 112165 | 112166 | 112167 | 112168 | 112169 | 112170 | 112171 | 112172 | 112201 | 112202 | 112203 | 112204 | 112205 | 112206 | 112207 | 112208 | 112209 | 112210 | 112211 | 112212 | 112213 | 112214 | 112215 | 112216 | 112217 | 112218 | 112219 | 112264 | 112265 | 112266 | 112267 | 112268 | 112269 | 112270 | 112271 | 112272 | 112292 | 112293 | 113108 | 113109 | 113116 | 113228 | 113229 | 113230 | 113231 | 113232 | 113233 | 113234 | 113235 | 113236