Attachment 112247 Details for Bug 26687 – Bug 26687: Add a Font Awesome icon for superlibrarian patrons

[patch] Bug 26687: Add a Font Awesome icon for superlibrarian patrons

Bug-26687-Add-a-Font-Awesome-icon-for-superlibrari.patch (text/plain), 2.25 KB, created by Katrin Fischer on 2020-10-23 10:36:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-10-23 10:36:26 UTC

Size: 2.25 KB

patch

obsolete

>From adf8495144d4bf28f13ff28975267e83aa1ab8ae Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 15 Oct 2020 10:48:52 +0200
>Subject: [PATCH] Bug 26687: Add a Font Awesome icon for superlibrarian patrons
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Bug 26534 adds a shield Font Awesome icon to help identify staff
>patrons. I propose to add an icon when patron is a superlibrarian.
>
>Patch adds 'is-superlibrarian' class that may be used for more CSS
>tuning.
>
>Test plan:
>1) Compare display between a patron A beeing superlibarian and a patron
>   B having only staff interface access
>2) Patron B has only shield icon
>3) Patron A has shield icon and bolt icon
>4) Check a patron without permissions has no shield icon
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 17f8f36f11..a35b058607 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -3,7 +3,13 @@
> [% PROCESS 'member-display-address-style.inc' %]
> [% IF ( patron.borrowernumber ) %]
> [% SET patron_is_staff = patron.has_permission({ 'catalogue' => 1 }) %]
>-[% SET patron_type_class = patron_is_staff ? 'is-staff' : 'is-not-staff' %]
>+[% SET patron_is_superlibrarian = patron.is_superlibrarian %]
>+[% SET patron_type_class = 'is-not-staff' %]
>+[% IF ( patron_is_superlibrarian ) %]
>+    [% patron_type_class = 'is-staff is-superlibrarian' %]
>+[% ELSIF ( patron_is_staff ) %]
>+    [% patron_type_class = 'is-staff' %]
>+[% END %]
> <div class="patroninfo [% patron_type_class | html %]">
> 
> [% IF ( patronimages ) %]
>@@ -14,6 +20,9 @@
>         [% IF ( patron_is_staff ) %]
>             <i class="fa fa-shield fa-fw" title="Staff patron"></i>
>         [% END %]
>+        [% IF ( patron_is_superlibrarian ) %]
>+            <i class="fa fa-bolt fa-fw" title="Superlibrarian patron"></i>
>+        [% END %]
>         [% INCLUDE 'patron-title.inc' %]
>     </h5>
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26687: 111686 | 111871 | 111875 | 112140 | 112141 | 112245 | 112247