Attachment 112276 Details for Bug 26799 – Bug 26799: Remove the use of jquery.checkboxes plugin from patron payment page

[patch] Bug 26799: Remove the use of jquery.checkboxes plugin from patron payment page

Bug-26799-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.30 KB, created by Owen Leonard on 2020-10-23 14:08:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-10-23 14:08:15 UTC

Size: 2.30 KB

patch

obsolete

>From 6662cbf984bcd585ca1c2781ed22a13a8b991f6a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 23 Oct 2020 13:54:01 +0000
>Subject: [PATCH] Bug 26799: Remove the use of jquery.checkboxes plugin from
> patron payment page
>
>This patch removes the use of the jquery.checkboxes plugin from the
>patron payment screen (members/pay.tt).
>
>To test, apply the patch and locate a patron with unpaid fines.
>
>- View the "Accounting" page for that patron.
>- In the table of outstanding fines, test the "Select all" and "Clear
>  all" links work correctly to check the checkboxes corresponding to
>  each fine.
>- Confirm that the "Select all" action enables the "Pay selected" and
>  "Write off selected" buttons.
>- Confirm that the "Clear all" action disables the "Pay selected" and
>  "Write off selected" buttons.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>index c66aecbf2d..746b63e391 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>@@ -172,7 +172,6 @@
> [% MACRO jsinclude BLOCK %]
>     [% INCLUDE 'str/members-menu.inc' %]
>     [% Asset.js("js/members-menu.js") | $raw %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     [% INCLUDE 'datatables.inc' %]
>     [% INCLUDE 'columns_settings.inc' %]
>     <script>
>@@ -200,15 +199,17 @@
>             });
>             $('#CheckAll').click(function(e){
>                 e.preventDefault();
>-                $("#finest").checkCheckboxes();
>+                $(".cb").each(function(){
>+                    $(this).prop("checked", true );
>+                });
>                 enableCheckboxActions();
>-                return false;
>             });
>             $('#CheckNone').click(function(e){
>                 e.preventDefault();
>-                $("#finest").unCheckCheckboxes();
>+                $(".cb").each(function(){
>+                    $(this).prop("checked", false );
>+                });
>                 enableCheckboxActions();
>-                return false;
>             });
>             $(".cb").change(function(){
>                 enableCheckboxActions();
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26799: 112276 | 112397 | 112442