Attachment 112351 Details for Bug 26760 – Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay"

[patch] Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay"

Bug-26760-Redirect-to-paycollectpl-when-clicking-o.patch (text/plain), 2.05 KB, created by Nick Clemens (kidclamp) on 2020-10-24 01:21:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-10-24 01:21:17 UTC

Size: 2.05 KB

patch

obsolete

>From f704f2f1879fa3b8ceb22789f27f6b0546ad3106 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Wed, 21 Oct 2020 12:58:29 +0200
>Subject: [PATCH] Bug 26760: Redirect to paycollect.pl when clicking on "Save
> and pay"
>
>Bug 14898 added the "Save and pay" button that redirects to "Make a
>payment" tab after creating a manual invoice
>This requires the user to click on another "Pay" button before being
>taken to the real payment form.
>By redirecting directly to paycollect.pl, this useless step will no
>longer be needed.
>
>Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> members/maninvoice.pl | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
>diff --git a/members/maninvoice.pl b/members/maninvoice.pl
>index a178a2be38..1062f74f83 100755
>--- a/members/maninvoice.pl
>+++ b/members/maninvoice.pl
>@@ -151,7 +151,7 @@ if ($add) {
> 
>     unless ($failed) {
>         try {
>-            $patron->account->add_debit(
>+            my $line = $patron->account->add_debit(
>                 {
>                     amount      => $amount,
>                     description => $desc,
>@@ -170,9 +170,18 @@ if ($add) {
>             }
> 
>             if ( $add eq 'save and pay' ) {
>-                print $input->redirect(
>-                    "/cgi-bin/koha/members/pay.pl?borrowernumber=$borrowernumber"
>+                my $url = sprintf(
>+                    '/cgi-bin/koha/members/paycollect.pl?borrowernumber=%s&pay_individual=1&debit_type_code=%s&amount=%s&amountoutstanding=%s&description=%s&itemnumber=%s&accountlines_id=%s',
>+                    $borrowernumber,
>+                    $line->debit_type_code,
>+                    sprintf('%.2f', $line->amount),
>+                    sprintf('%.2f', $line->amountoutstanding),
>+                    $line->description,
>+                    $line->itemnumber,
>+                    $line->id
>                 );
>+
>+                print $input->redirect($url);
>             }
>             else {
>                 print $input->redirect(
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26760: 112093 | 112313 | 112351 | 120856 | 122577 | 122578