Attachment 112396 Details for Bug 26800 – Attachment to Bug 26800 - Remove the use of jquery.checkboxes plugin from checkout page

[patch] Attachment to Bug 26800 - Remove the use of jquery.checkboxes plugin from checkout page

Bug-26800-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.36 KB, created by Lisette Scheer on 2020-10-24 20:08:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lisette Scheer

Created: 2020-10-24 20:08:44 UTC

Size: 2.36 KB

patch

obsolete

>From cb8aefa139c93a260bb073ab97aaac20645b25c5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 23 Oct 2020 14:42:35 +0000
>Subject: [PATCH] Bug 26800: Remove the use of jquery.checkboxes plugin from
> checkout page
>
>This patch removes inclusion of the jquery.checkboxes plugin from the
>patron checkout page (circulation.tt). The plugin is unused.
>
>To test, apply the patch and check out to a patron with checkouts.
>
>- Open the checkouts tab and click "Show checkouts" if necessary.
>- In the table of checkouts, confirm that the "select all" and "none"
>  links in the "Renew" and "Check in" column headers work correctly.
>
>Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt  | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
>index 1efa03b568..fb824ebf1d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
>@@ -6,7 +6,7 @@
>                 <a id="issues-table-load-now-button" href="#" class="btn btn-default"><i class="fa fa-book"></i> Show checkouts</a>
>             </p>
>         </div>
>-        <form name="issues" action="/cgi-bin/koha/tools/export.pl" method="post" class="checkboxed">
>+        <form name="issues" action="/cgi-bin/koha/tools/export.pl" method="post">
>             <table id="issues-table" style="width: 100% !Important;">
>                 <thead>
>                     <tr>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 056d40519d..aaccb2f045 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -1070,7 +1070,6 @@
>     [% INCLUDE 'calendar.inc' %]
>     [% INCLUDE 'datatables.inc' %]
>     [% INCLUDE 'columns_settings.inc' %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
>     [% Asset.js("lib/jquery/plugins/jquery-ui-timepicker-addon.min.js") | $raw %]
>     [% INCLUDE 'timepicker.inc' %]
>     [% Asset.js("lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js") | $raw %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26800: 112294 | 112396 | 112440