Attachment 112422 Details for Bug 24083 – Bug 24083: (follow-up) Fix misaligned columns

[patch] Bug 24083: (follow-up) Fix misaligned columns

Bug-24083-follow-up-Fix-misaligned-columns.patch (text/plain), 1.84 KB, created by Katrin Fischer on 2020-10-24 23:53:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-10-24 23:53:15 UTC

Size: 1.84 KB

patch

obsolete

>From ba0fcb11f36021b9543cdbee390642938553fe65 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Fri, 23 Oct 2020 09:36:13 +0100
>Subject: [PATCH] Bug 24083: (follow-up) Fix misaligned columns
>
>Somehow I'd never noticed this before but the columns in smart-rules.tt
>were misaligned when UnseenRenewals was turned off. This was due to the
>display of a <td> not being conditional when it should have been. This
>is now fixed.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index d60c758119..05450a44dc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -413,7 +413,9 @@
>                     <td><input type="text" name="maxsuspensiondays" id="maxsuspensiondays" size="3" /> </td>
>                     <td><input type="text" name="suspension_chargeperiod" id="suspension_chargeperiod" size="3" /> </td>
>                     <td><input type="text" name="renewalsallowed" id="renewalsallowed" size="2" /></td>
>-                    <td><input type="text" name="unseen_renewals_allowed" id="unseen_renewals_allowed" size="2" /></td>
>+                    [% IF Koha.Preference('UnseenRenewals') %]
>+                        <td><input type="text" name="unseen_renewals_allowed" id="unseen_renewals_allowed" size="2" /></td>
>+                    [% END %]
>                     <td><input type="text" name="renewalperiod" id="renewalperiod" size="3" /></td>
>                     <td><input type="text" name="norenewalbefore" id="norenewalbefore" size="3" /></td>
>                     <td>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24083: 95861 | 95862 | 95863 | 95864 | 95865 | 95866 | 95867 | 95868 | 98749 | 98750 | 98751 | 98752 | 98765 | 98766 | 98767 | 98768 | 100244 | 100245 | 100246 | 100247 | 100380 | 100381 | 100382 | 100383 | 100392 | 110607 | 110608 | 110609 | 110610 | 110611 | 111147 | 111148 | 111149 | 111150 | 111151 | 111152 | 111283 | 111284 | 111285 | 111286 | 111287 | 111288 | 111289 | 111290 | 111291 | 111292 | 111293 | 111849 | 111850 | 111851 | 111852 | 111853 | 111854 | 111855 | 111856 | 111857 | 111858 | 111859 | 111860 | 112230 | 112231 | 112232 | 112233 | 112234 | 112235 | 112236 | 112237 | 112238 | 112239 | 112240 | 112241 | 112242 | 112243 | 112410 | 112411 | 112412 | 112413 | 112414 | 112415 | 112416 | 112417 | 112418 | 112419 | 112420 | 112421 | 112422 | 112423 | 113073 | 113074 | 113075 | 113076 | 113077 | 113078 | 113079 | 113080 | 113314 | 113315 | 113484 | 113485 | 113486 | 113487 | 113488 | 113489 | 113490 | 113491 | 113492 | 113493 | 113494 | 113546 | 113556 | 113557 | 113814