Attachment 112428 Details for Bug 26232 – Bug 26232: Empty smart rule fine grace period

[patch] Bug 26232: Empty smart rule fine grace period

Bug-26232-Empty-smart-rule-fine-grace-period.patch (text/plain), 1.14 KB, created by Nick Clemens (kidclamp) on 2020-10-25 00:05:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-10-25 00:05:33 UTC

Size: 1.14 KB

patch

obsolete

>From fa9301eb223a9089957ee5384c5b1fc5247f03a6 Mon Sep 17 00:00:00 2001
>From: Didier Gautheron <didier.gautheron@biblibre.com>
>Date: Tue, 18 Aug 2020 07:40:50 +0200
>Subject: [PATCH] Bug 26232: Empty smart rule fine grace period
>
>Staff can create smart rules with empty (undefined) fine grace period.
>In Overdues.pm undefined firstremind means 0, do the same in Circulation.pm.
>
>To test:
>1. Apply these patches
>2. Run:
>   kshell
>   prove t/db_dependent/Circulation.t
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 18c4dacda5..61a85a3b8e 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2351,7 +2351,7 @@ sub _calculate_new_debar_dt {
> 
>     # grace period is measured in the same units as the loan
>     my $grace =
>-      DateTime::Duration->new( $unit => $issuing_rule->{firstremind} );
>+      DateTime::Duration->new( $unit => $issuing_rule->{firstremind} // 0);
> 
>     my $deltadays = DateTime::Duration->new(
>         days => $chargeable_units
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26232: 108432 | 108433 | 108434 | 111034 | 112403 | 112404 | 112427 | 112428