Attachment 112457 Details for Bug 26763 – Bug 26763: Use standard information style for multi-hold message

[patch] Bug 26763: Use standard information style for multi-hold message

Bug-26763-Use-standard-information-style-for-multi.patch (text/plain), 2.62 KB, created by Nick Clemens (kidclamp) on 2020-10-25 02:22:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-10-25 02:22:47 UTC

Size: 2.62 KB

patch

obsolete

>From 0e5024997a77cf3e77423e135793d7e88bc92a4a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 21 Oct 2020 12:07:19 +0000
>Subject: [PATCH] Bug 26763: Use standard information style for multi-hold
> message
>
>This patch modifies the markup of the message which is displayed when
>the patron tries to place a hold on a title they already have a hold on.
>Now the message is styled consistently with other similar messages.
>
>To test, apply the patch and follow the steps used to test Bug 19718:
>
>- In Administration -> Circulation and fine rules, set a rule to allow
>  multiple holds on a title.
>- Log in to the OPAC as a user covered by the above rule and locate
>  a bibliographic record on which multiple holds can be placed.
>- Place a hold on the record.
>- Return to the record details for that title and place another hold.
>- You should see a correctly-styled message about having at least one
>  other hold on the record.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index 1b9dd3bdee..5dc03cf521 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -167,7 +167,7 @@
>                                     [% IF ( bibitemloo.holdable ) %]
>                             <div class="holdrow">
>                                 [% IF bibitemloo.forced_hold_level %]
>-                                    <span class="forced_hold_level"><h3>
>+                                    <div class="alert alert-info forced_hold_level">
>                                         [% IF bibitemloo.forced_hold_level == 'item' %]
>                                             You already have at least one item level hold on this title.
>                                             All further holds must be item level.
>@@ -175,7 +175,7 @@
>                                             You already have at least one record level hold on this title.
>                                             All further holds must be record level.
>                                         [% END %]
>-                                    </h3></span>
>+                                    </div>
>                                 [% END %]
>                                 <p>
>                                         <input class="reserve_mode" name="reserve_mode" type="hidden" value="single"/>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26763: 112095 | 112452 | 112457 | 112458