Bugzilla – Attachment 11255 Details for
Bug 8485
Make koha_perl_deps.pl batch friendly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries.
Bug-8485---Make-kohaperldepspl-batch-friendly-Adde.patch (text/plain), 3.97 KB, created by
Tomás Cohen Arazi (tcohen)
on 2012-08-01 13:35:17 UTC
(
hide
)
Description:
Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries.
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2012-08-01 13:35:17 UTC
Size:
3.97 KB
patch
obsolete
>From a1c775f0f78db6c3efffc70d294cab6c7b0942ab Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 31 Jul 2012 23:09:27 +0800 >Subject: [PATCH] Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b > flag for brief which outputs only the perl library name > (Foo::BaR), and added a -r flag for required which filters > the list to required=Yes perl libraries. >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > koha_perl_deps.pl | 60 ++++++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 46 insertions(+), 14 deletions(-) > >diff --git a/koha_perl_deps.pl b/koha_perl_deps.pl >index 01e17d5..123bcd2 100755 >--- a/koha_perl_deps.pl >+++ b/koha_perl_deps.pl >@@ -18,6 +18,8 @@ my $installed = 0; > my $upgrade = 0; > my $all = 0; > my $color = 0; >+my $brief = 0; >+my $req = 0; > > GetOptions( > 'h|help|?' => \$help, >@@ -25,6 +27,8 @@ GetOptions( > 'i|installed' => \$installed, > 'u|upgrade' => \$upgrade, > 'a|all' => \$all, >+ 'b|brief' => \$brief, >+ 'r|required' => \$req, > 'c|color' => \$color, > ); > >@@ -39,12 +43,14 @@ push @pm, 'missing_pm' if $missing || $all; > push @pm, 'upgrade_pm' if $upgrade || $all; > push @pm, 'current_pm' if $installed || $all; > >-print color 'bold blue' if $color; >-print" >+if (!$brief) { >+ print color 'bold blue' if $color; >+ print" > Installed Required Module is > Module Name Version Version Required > -------------------------------------------------------------------------------------------- > "; >+} > > my $count = 0; > foreach my $type (@pm) { >@@ -60,28 +66,40 @@ foreach my $type (@pm) { > my $required = ($_->{$pm}->{'required'}?'Yes':'No'); > my $current_version = ($color ? $_->{$pm}->{'cur_ver'} : > $type eq 'missing_pm' || $type eq 'upgrade_pm' ? $_->{$pm}->{'cur_ver'}." *" : $_->{$pm}->{'cur_ver'}); >+ if (!$brief) { >+ if (($req && $required eq 'Yes') || !$req) { > format = > @<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<< > $pm, $current_version, $_->{$pm}->{'min_ver'}, $required > . > write; >+ } >+ } >+ else { >+ if (($req && $required eq 'Yes') || !$req) { >+ print "$pm\n"; >+ } >+ } > } > } > } >-print color 'bold blue' if $color; >-my $footer = " >+ >+if (!$brief) { >+ print color 'bold blue' if $color; >+ my $footer = " > -------------------------------------------------------------------------------------------- > Total modules reported: $count "; > >-if ($color) { >- $footer .= "\n\n"; >-} >-else { >- $footer .= "* Module is missing or requires an upgrade.\n\n"; >-} >+ if ($color) { >+ $footer .= "\n\n"; >+ } >+ else { >+ $footer .= "* Module is missing or requires an upgrade.\n\n"; >+ } > >-print $footer; >-print color 'reset' if $color; >+ print $footer; >+ print color 'reset' if $color; >+} > > 1; > >@@ -93,7 +111,12 @@ koha_perl_deps.pl > > =head1 SYNOPSIS > >-./koha_perl_deps.pl -m >+ At least one of -a, -m, -i, or -u flags must specified to not trigger help. >+ ./koha_perl_deps.pl -m [-b] [-r] [-c] >+ ./koha_perl_deps.pl -u [-b] [-r] [-c] >+ ./koha_perl_deps.pl -i [-b] [-r] [-c] >+ ./koha_perl_deps.pl -a [-b] [-r] [-c] >+ ./koha_perl_deps.pl [-[h?]] > > =head1 OPTIONS > >@@ -113,7 +136,16 @@ lists all perl modules needing to be upgraded relative to Koha > > =item B<-a|--all> > >-lists all koha perl dependencies >+ lists all koha perl dependencies >+ This is equivalent to '-m -i -u'. >+ >+=item B<-b|--brief> >+ >+lists only the perl dependency name. >+ >+=item B<-r|--required> >+ >+filters list to only required perl dependencies. > > =item B<-c|--color> > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8485
:
11220
|
11255
|
11342