Attachment 11257 Details for Bug 8385 – Bug 8385: Dirty patch to make tt_valid.t happy

[patch] Bug 8385: Dirty patch to make tt_valid.t happy

Bug-8385-Dirty-patch-to-make-ttvalidt-happy.patch (text/plain), 4.29 KB, created by Jonathan Druart on 2012-08-01 13:41:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2012-08-01 13:41:08 UTC

Size: 4.29 KB

patch

obsolete

>From 96cbc3f3bd6d0949a405113a9fc11bd2f6d90f98 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 1 Aug 2012 15:35:21 +0200
>Subject: [PATCH] Bug 8385: Dirty patch to make tt_valid.t happy
>
>A problem in routine text_replace_tag (tmpl_process3.pl) have to be
>fixed to prevent this kind of dirty patch :)
>---
> .../en/modules/admin/searchengine/solr/indexes.tt  |   48 ++++++++++++++++---
> 1 files changed, 40 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt
>index 2ccbe5a..7f5be96 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/solr/indexes.tt
>@@ -129,19 +129,51 @@
>                   [% IF ( index.mandatory ) %]
>                     <input type="hidden" name="type" value="[% index.type %]" />
>                   [% END %]
>-                  <select name="type"[% IF ( index.mandatory ) %] disabled="disabled"[% END %]>
>-                    <option [% IF ( index.type == 'str' ) %] selected="selected"[% END %] value="str">String</option>
>-                    <option [% IF ( index.type == 'ste' ) %] selected="selected"[% END %] value="ste">Simple Text</option>
>-                    <option [% IF ( index.type == 'txt' ) %] selected="selected"[% END %] value="txt">Text</option>
>-                    <option [% IF ( index.type == 'int' ) %] selected="selected"[% END %] value="int">Integer</option>
>-                    <option [% IF ( index.type == 'date') %] selected="selected"[% END %] value="date">Date</option>
>+                  [% IF ( index.mandatory ) %]
>+                    <select name="type" disabled="disabled">
>+                  [% ELSE %]
>+                    <select name="type">
>+                  [% END %]
>+                    [% IF ( index.type == 'str' ) %]
>+                        <option value="str" selected="selected">String</option>
>+                    [% ELSE %]
>+                        <option value="str">String</option>
>+                    [% END %]
>+                    [% IF ( index.type == 'ste' ) %]
>+                        <option value="ste" selected="selected">Simple Text</option>
>+                    [% ELSE %]
>+                        <option value="ste">Simple Text</option>
>+                    [% END %]
>+                    [% IF ( index.type == 'txt' ) %]
>+                        <option value="txt" selected="selected">Text</option>
>+                    [% ELSE %]
>+                        <option value="txt">Text</option>
>+                    [% END %]
>+                    [% IF ( index.type == 'int' ) %]
>+                        <option value="int" selected="selected">Integer</option>
>+                    [% ELSE %]
>+                        <option value="int">Integer</option>
>+                    [% END %]
>+                    [% IF ( index.type == 'date' ) %]
>+                        <option value="date" selected="selected">Date</option>
>+                    [% ELSE %]
>+                        <option value="date">Date</option>
>+                    [% END %]
>                   </select>
>                 </td>
>                 <td>
>-                  <input name="sortable" type="checkbox" [% IF ( index.sortable ) %]checked="checked"[% END %] value="[% index.code %]" />
>+                  [% IF ( index.sortable ) %]
>+                    <input name="sortable" type="checkbox" checked="checked" value="[% index.code %]" />
>+                  [% ELSE %]
>+                    <input name="sortable" type="checkbox" value="[% index.code %]" />
>+                  [% END %]
>                 </td>
>                 <td>
>-                  <input name="facetable" type="checkbox" [% IF ( index.facetable ) %]checked="checked"[% END %] value="[% index.code %]" />
>+                  [% IF ( index.facetable ) %]
>+                    <input name="facetable" type="checkbox" checked="checked" value="[% index.code %]" />
>+                  [% ELSE %]
>+                    <input name="facetable" type="checkbox" value="[% index.code %]" />
>+                  [% END %]
>                 </td>
>                 <td>
>                     <textarea name="mappings" class="contentEditable">[% FOREACH m IN index.mappings %][% m %]
>-- 
>1.7.7.3

Actions: View | Diff | Splinter Review

Attachments on bug 8385: 10807 | 10875 | 10916 | 11257