Attachment 112711 Details for Bug 26844 – Bug 26844: Add warning to disabled logs on log viewer

[patch] Bug 26844: Add warning to disabled logs on log viewer

Bug-26844-Add-warning-to-disabled-logs-on-log-view.patch (text/plain), 3.72 KB, created by Tomás Cohen Arazi (tcohen) on 2020-10-30 14:43:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-10-30 14:43:21 UTC

Size: 3.72 KB

patch

obsolete

>From 077636916c80584d6bc161da88e6e023866785c9 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 28 Oct 2020 12:34:01 +0000
>Subject: [PATCH] Bug 26844: Add warning to disabled logs on log viewer
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To test:
>1 - Go to Admin->System preferences->Logs tab
>2 - Make sure some logs are disabled
>3 - Go to Tools->Log viewer
>4 - Note you can select logs that are disabled
>5 - Apply patch
>6 - Reload page
>7 - Note disabled logs have a warning icon and hover text
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../prog/en/modules/tools/viewlog.tt | 39 ++++++++++++-------
> 1 file changed, 26 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>index 1a1f8fb18c4..22a17720c87 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>@@ -67,20 +67,33 @@
> 
> [% BLOCK translate_log_module %]
> [% SWITCH module %]
>-[% CASE 'AUTH' %]Authentication
>-[% CASE 'CATALOGUING' %]Catalog
>-[% CASE 'AUTHORITIES' %]Authorities
>-[% CASE 'MEMBERS' %]Patrons
>-[% CASE 'ACQUISITIONS' %]Acquisitions
>-[% CASE 'SERIAL' %]Serials
>-[% CASE 'HOLDS' %]Holds
>-[% CASE 'ILL' %]Interlibrary loans
>-[% CASE 'CIRCULATION' %]Circulation
>-[% CASE 'LETTER' %]Letter
>-[% CASE 'FINES' %]Fines
>+[% CASE 'AUTH' %]Authentication[% UNLESS Koha.Preference('AuthFailureLog') || Koha.Preference('AuthScuccessLog') %] [% END %]
>+[% CASE 'CATALOGUING' %]Catalog[% UNLESS Koha.Preference('CataloguingLog') %] [% END %]
>+
>+[% CASE 'AUTHORITIES' %]Authorities[% UNLESS Koha.Preference('AuthoritiesLog') %] [% END %]
>+
>+[% CASE 'MEMBERS' %]Patrons[% UNLESS Koha.Preference('BorrowersLog') %] [% END %]
>+
>+[% CASE 'ACQUISITIONS' %]Acquisitions 
>+
>+[% CASE 'SERIAL' %]Serials[% UNLESS Koha.Preference('SubscriptionLog') %] [% END %]
>+
>+[% CASE 'HOLDS' %]Holds[% UNLESS Koha.Preference('HoldsLog') %] [% END %]
>+
>+[% CASE 'ILL' %]Interlibrary loans[% UNLESS Koha.Preference('IllLog') %] [% END %]
>+
>+[% CASE 'CIRCULATION' %]Circulation[% UNLESS Koha.Preference('IssueLog') %] [% END %]
>+
>+[% CASE 'LETTER' %]Letter[% UNLESS Koha.Preference('LetterLog') %] [% END %]
>+
>+[% CASE 'FINES' %]Fines[% UNLESS Koha.Preference('FinesLog') %] [% END %]
>+
> [% CASE 'SYSTEMPREFERENCE' %]System prefs
>-[% CASE 'CRONJOBS' %]Cron jobs
>-[% CASE 'REPORTS' %]Reports
>+
>+[% CASE 'CRONJOBS' %]Cron jobs[% UNLESS Koha.Preference('CronjobLog') %] [% END %]
>+
>+[% CASE 'REPORTS' %]Reports[% UNLESS Koha.Preference('ReportsLog') %] [% END %]
>+
> [% CASE %][% module | html %]
> [% END %]
> [% END %]
>-- 
>2.29.1

Actions: View | Diff | Splinter Review

Attachments on bug 26844: 112636 | 112689 | 112711