Attachment 112728 Details for Bug 26817 – Bug 26817: Change checkouts table footer colspan based on ExportCircHistory

[patch] Bug 26817: Change checkouts table footer colspan based on ExportCircHistory

Bug-26817-Change-checkouts-table-footer-colspan-ba.patch (text/plain), 2.15 KB, created by Séverine Queune on 2020-10-30 16:52:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Séverine Queune

Created: 2020-10-30 16:52:36 UTC

Size: 2.15 KB

patch

obsolete

>From c6fbe08e39cd342b547e8627e2019bb9624fcc2a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 26 Oct 2020 12:31:16 +0000
>Subject: [PATCH] Bug 26817: Change checkouts table footer colspan based on
> ExportCircHistory
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch makes a minor change to the include file which generates the
>checkouts table footer. It now includes some logic checking for the
>ExportCircHistory system preference, adjusting the colspan accordingly.
>
>To test, apply the patch and enable the ExportCircHistory system
>preference.
>
>- Check out to a patron who has checkouts. In the table of checkouts
>  there should be an "Export" column. The footer at the bottom of the
>  table should span the width of the table.
>- Disable the ExportCircHistory preference.
>- View the checkout page again and confirm that table footer still looks
>  correct.
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc
>index 9b62491..483e33e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc
>@@ -4,7 +4,11 @@
>         <td id="totaldue" style="text-align: right;"></td>
>         <td id="totalfine" style="text-align: right;"></td>
>         <td id="totalprice" style="text-align: right;"></td>
>-        <td colspan="3">
>+        [% IF Koha.Preference('ExportCircHistory') %]
>+            <td colspan="4">
>+        [% ELSE %]
>+            <td colspan="3">
>+        [% END %]
>             <div class="date-select">
>                 <p><label for="newduedate">Renewal due date:</label> <input type="text" size="12" id="newduedate" name="newduedate" value="" /></p>
>                 <p id="newonholdduedate"><label for="newonholdduedate">On hold due date:</label> <input type="text" size="12" name="newonholdduedate" value="" /></p>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 26817: 112517 | 112728 | 112776