Bugzilla – Attachment 112766 Details for
Bug 26758
Correct OPAC ILL requests page markup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26758: Correct OPAC ILL requests page markup
Bug-26758-Correct-OPAC-ILL-requests-page-markup.patch (text/plain), 5.62 KB, created by
David Nind
on 2020-10-31 21:36:05 UTC
(
hide
)
Description:
Bug 26758: Correct OPAC ILL requests page markup
Filename:
MIME Type:
Creator:
David Nind
Created:
2020-10-31 21:36:05 UTC
Size:
5.62 KB
patch
obsolete
>From 29af5645b637fa84a17f13b38b64e895ece9faf0 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 21 Oct 2020 01:49:08 +0000 >Subject: [PATCH] Bug 26758: Correct OPAC ILL requests page markup > >This patch makes some corrections to the OPAC ILL page which should have >been included in the upgrade to Bootstrap 4. > >To test you must have Interlibrary loan configured and enabled in the >OPAC. Enter some text in the ILLModuleCopyrightClearance system >preference. > >- Log in to the OPAC and go to the "your interlibrary loan requests" > page. >- If you have only one ILL backend set up you should see a "Create a new > request" button which is styled correctly. > - This patch makes corrections to the menu which displays if you have > more than one ILL backend set up, so it would be ideal to be able to > test it. >- Upon clickng the "new request" button (or selecting a backend from the > new request menu) you should be prompted to choose Yes or No in > response to the ILLModuleCopyrightClearance text. The buttons should > be styled green and red, respectively. >- On the new request entry page the "Add new field" and "Create" buttons > should be styled in the "secondary" grey style. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index f358542988..22edcc4d30 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -78,9 +78,9 @@ > </p> > [% USE link_url = url('/cgi-bin/koha/opac-illrequests.pl', whole.value.other) %] > <a href="[% link_url _ '&stage=copyrightclearance' | $raw %]" >- class="btn btn-sm btn-default"><i class="fa fa-check" aria-hidden="true"></i> Yes</a> >+ class="btn btn-sm btn-primary"><i class="fa fa-check" aria-hidden="true"></i> Yes</a> > <a href="/cgi-bin/koha/opac-illrequests.pl" >- class="btn btn-sm btn-default"><i class="fa fa-times" aria-hidden="true"></i> No</a> >+ class="btn btn-sm btn-danger"><i class="fa fa-times" aria-hidden="true"></i> No</a> > </div> > [% ELSE %] > [% INCLUDE messages %] >@@ -109,16 +109,16 @@ > > <div id="illrequests-create-button" class="dropdown btn-group"> > [% IF backends.size > 1 %] >- <button class="btn btn-default dropdown-toggle" type="button" id="ill-backend-dropdown" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true"> >+ <button class="btn btn-primary dropdown-toggle" type="button" id="ill-backend-dropdown" data-toggle="dropdown" aria-haspopup="true" aria-expanded="true"> > <i class="fa fa-plus" aria-hidden="true"></i> Create a new request <span class="caret"></span> > </button> >- <ul id="backend-dropdown-options" class="dropdown-menu nojs" aria-labelledby="ill-backend-dropdown"> >+ <div id="backend-dropdown-options" class="dropdown-menu nojs" aria-labelledby="ill-backend-dropdown"> > [% FOREACH backend IN backends %] >- <li><a href="/cgi-bin/koha/opac-illrequests.pl?method=create&backend=[% backend | uri %]">[% backend | html %]</a></li> >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-illrequests.pl?method=create&backend=[% backend | uri %]">[% backend | html %]</a> > [% END %] >- </ul> >+ </div> > [% ELSE %] >- <a id="ill-new" class="btn btn-default" href="/cgi-bin/koha/opac-illrequests.pl?method=create&backend=[% backends.0 | html %]"> >+ <a id="ill-new" class="btn btn-primary" href="/cgi-bin/koha/opac-illrequests.pl?method=create&backend=[% backends.0 | html %]"> > <i class="fa fa-plus" aria-hidden="true"></i> Create a new request > </a> > [% END %] >@@ -233,7 +233,7 @@ > [% IF request.status == "NEW" %] > <a class="cancel-illrequest btn btn-danger" href="/cgi-bin/koha/opac-illrequests.pl?method=cancreq&illrequest_id=[% request.illrequest_id | html %]">Request cancellation</a> > [% END %] >- <input type="submit" class="update-illrequest btn btn-default" value="Submit modifications" /> >+ <input type="submit" class="update-illrequest btn btn-primary" value="Submit modifications" /> > [% END %] > <span class="cancel"><a href="/cgi-bin/koha/opac-illrequests.pl">Cancel</a></span> > </fieldset> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26758
:
112085
|
112766
|
112767
|
112771