Bugzilla – Attachment 112833 Details for
Bug 25167
Fix not for loan filter in inventory tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25167: Fix to a fix wrong inventory results
Bug-25167-Fix-to-a-fix-wrong-inventory-results.patch (text/plain), 2.02 KB, created by
Nick Clemens (kidclamp)
on 2020-11-02 13:45:40 UTC
(
hide
)
Description:
Bug 25167: Fix to a fix wrong inventory results
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-11-02 13:45:40 UTC
Size:
2.02 KB
patch
obsolete
>From 0af67daa9932cdb78edab0646cb44a615f925c7c Mon Sep 17 00:00:00 2001 >From: Didier Gautheron <didier.gautheron@biblibre.com> >Date: Wed, 8 Apr 2020 09:33:44 +0200 >Subject: [PATCH] Bug 25167: Fix to a fix wrong inventory results >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan : >- Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, > for example 'NOTFORLOAN' >- Create a new value in this category, for example '9' >- Create a biblio with default framework >- Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 >- Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 >- Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' >- Go to inventory tool : /cgi-bin/koha/tools/inventory.pl >- Choose file in 'Barcode file' >- Enter item callnumber between 'A-0' and 'A-9' >- Check 'Compare barcodes list to results' >- Submit=> without patch, you get no warnings >- Redo the same inventory but with checking items.notforloan 'For loan' > (using the browser back page is ok) >- submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' >- Apply patch, repeat, with tems.notforloan 'For loan' checked you get the > right warning > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > tools/inventory.pl | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/tools/inventory.pl b/tools/inventory.pl >index 04896654a7..5c4fbeaea4 100755 >--- a/tools/inventory.pl >+++ b/tools/inventory.pl >@@ -119,6 +119,13 @@ for my $authvfield (@$statuses) { > } > } > >+# if there's a list of not for loans types selected use it rather than >+# the full set. >+if ($staton->{'items.notforloan'}) { >+ my @l = @{$staton->{'items.notforloan'}}; >+ @notforloans = @l if scalar @l > 0; >+} >+ > my @class_sources = Koha::ClassSources->search({ used => 1 }); > my $pref_class = C4::Context->preference("DefaultClassificationSource"); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25167
:
105374
|
112262
|
112353
| 112833 |
112834